Skip to content

Commit

Permalink
Upgrade puppeteer to 5.5.0 (#28055)
Browse files Browse the repository at this point in the history
* Upgrade puppeteer to 5.5.0

* Fix destroyed execution context

* Update CHANGELOG
  • Loading branch information
kevin940726 authored Jan 11, 2021
1 parent 1af35a5 commit 8671961
Show file tree
Hide file tree
Showing 5 changed files with 74 additions and 27 deletions.
91 changes: 67 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@
"postcss-loader": "3.0.0",
"prettier": "npm:[email protected]",
"progress": "2.0.3",
"puppeteer": "npm:puppeteer-core@3.0.0",
"puppeteer": "npm:puppeteer-core@5.5.0",
"react": "16.13.1",
"react-dom": "16.13.1",
"react-native": "0.61.5",
Expand Down
5 changes: 4 additions & 1 deletion packages/e2e-test-utils/src/change-site-timezone.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ export async function changeSiteTimezone( timezone ) {
( element ) => element.options[ element.selectedIndex ].text
);
await page.select( '#timezone_string', timezone );
await page.click( '#submit' );
await Promise.all( [
page.click( '#submit' ),
page.waitForNavigation( { waitUntil: 'networkidle0' } ),
] );

await switchUserToTest();

Expand Down
1 change: 1 addition & 0 deletions packages/scripts/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- The bundled `jest` dependency has been updated to the next major version `^26.6.3` (see [Breaking Changes](https://jestjs.io/blog/2020/05/05/jest-26), [#27956](https://github.com/WordPress/gutenberg/pull/27956)).
- The bundled `@wordpress/eslint-plugin` dependency has been updated to the next major version `^8.0.0`. There are new ESLint rules enabled in the recommended config used by `lint-js` command.
- The bundled `stylelint-config-wordpress` dependency has been replaced with `@wordpress/stylelint-config` (#27810)[https://github.com/WordPress/gutenberg/pull/27810].
- The bundled `puppeteer-core` (`3.0.0`) dependency has been upgraded to version `5.5.0`. Puppeteer uses Chromium v88 instead of Chromium v71. See the full list of breaking changes of [4.0.0](https://github.com/puppeteer/puppeteer/releases/tag/v4.0.0) and [5.0.0](https://github.com/puppeteer/puppeteer/releases/tag/v5.0.0).

### Enhancements

Expand Down
2 changes: 1 addition & 1 deletion packages/scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"npm-package-json-lint": "^5.0.0",
"postcss-loader": "^3.0.0",
"prettier": "npm:[email protected]",
"puppeteer": "npm:puppeteer-core@3.0.0",
"puppeteer": "npm:puppeteer-core@5.5.0",
"read-pkg-up": "^1.0.1",
"resolve-bin": "^0.4.0",
"sass": "^1.26.11",
Expand Down

0 comments on commit 8671961

Please sign in to comment.