Skip to content

Commit

Permalink
Inserter: Disallow container tabbable when visible
Browse files Browse the repository at this point in the history
Prevents shift-tab focus trap which can occur while button is focused, since focusFirstTabbable would continue to keep button focused
  • Loading branch information
aduth committed Oct 16, 2017
1 parent 069f8d2 commit 80023c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion editor/modes/visual-editor/sibling-inserter.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class VisualEditorSiblingInserter extends Component {
onBlur={ this.hide }
onMouseEnter={ this.show }
onMouseLeave={ this.hide }
tabIndex={ 0 }>
tabIndex={ isVisible ? -1 : 0 }>
{ showInsertionPoint && (
<div className="editor-visual-editor__insertion-point" />
) }
Expand Down

0 comments on commit 80023c1

Please sign in to comment.