Lodash: Refactor away from _.deburr() (#43118)

WordPress · Aug 12, 2022 · 7848b73 · 7848b73
1 parent 3ec3f09
commit 7848b73
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -85,6 +85,7 @@ module.exports = {
 							'compact',
 							'concat',
 							'countBy',
+							'deburr',
 							'defaults',
 							'defaultTo',
 							'delay',

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/blocks/package.json b/packages/blocks/package.json
@@ -47,6 +47,7 @@
 		"lodash": "^4.17.21",
 		"memize": "^1.1.0",
 		"rememo": "^4.0.0",
+		"remove-accents": "^0.4.2",
 		"showdown": "^1.9.1",
 		"simple-html-tokenizer": "^0.5.7",
 		"uuid": "^8.3.0"

diff --git a/packages/blocks/src/store/selectors.js b/packages/blocks/src/store/selectors.js
@@ -2,7 +2,8 @@
  * External dependencies
  */
 import createSelector from 'rememo';
-import { deburr, filter, flow, get, includes, map, some } from 'lodash';
+import removeAccents from 'remove-accents';
+import { filter, flow, get, includes, map, some } from 'lodash';
 
 /** @typedef {import('../api/registration').WPBlockVariation} WPBlockVariation */
 /** @typedef {import('../api/registration').WPBlockVariationScope} WPBlockVariationScope */
@@ -688,7 +689,7 @@ export function isMatchingSearchTerm( state, nameOrType, searchTerm ) {
 	const getNormalizedSearchTerm = flow( [
 		// Disregard diacritics.
 		//  Input: "média"
-		deburr,
+		( term ) => removeAccents( term ?? '' ),
 
 		// Lowercase.
 		//  Input: "MEDIA"