Skip to content

Commit

Permalink
Components: Also ignore no-node-access for some components (#46501)
Browse files Browse the repository at this point in the history
  • Loading branch information
tyxla authored Dec 13, 2022
1 parent dd0504b commit 6a54882
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/components/src/range-control/test/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ describe( 'RangeControl', () => {
/>
);

// eslint-disable-next-line testing-library/no-container
// eslint-disable-next-line testing-library/no-container, testing-library/no-node-access
const beforeIcon = container.querySelector(
'.dashicons-format-image'
);
// eslint-disable-next-line testing-library/no-container
// eslint-disable-next-line testing-library/no-container, testing-library/no-node-access
const afterIcon = container.querySelector(
'.dashicons-format-video'
);
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/tooltip/test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ describe( 'Tooltip', () => {
// Note: this is testing for implementation details,
// but couldn't find a better way.
const buttonRect = button.getBoundingClientRect();
// eslint-disable-next-line testing-library/no-container
// eslint-disable-next-line testing-library/no-container, testing-library/no-node-access
const eventCatcher = container.querySelector( '.event-catcher' );
const eventCatcherRect = eventCatcher.getBoundingClientRect();
expect( buttonRect ).toEqual( eventCatcherRect );
Expand Down Expand Up @@ -252,7 +252,7 @@ describe( 'Tooltip', () => {
</Tooltip>
);

// eslint-disable-next-line testing-library/no-container
// eslint-disable-next-line testing-library/no-container, testing-library/no-node-access
const eventCatcher = container.querySelector( '.event-catcher' );
await user.click( eventCatcher );
expect( onClickMock ).not.toHaveBeenCalled();
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/unit-control/test/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ describe( 'UnitControl', () => {
withoutClassName.querySelector( '.components-unit-control' )
).not.toHaveClass( 'hello' );
expect(
// eslint-disable-next-line testing-library/no-container
// eslint-disable-next-line testing-library/no-container, testing-library/no-node-access
withClassName.querySelector( '.components-unit-control' )
).toHaveClass( 'hello' );
} );
Expand Down

0 comments on commit 6a54882

Please sign in to comment.