Skip to content

Commit

Permalink
use same px value for all cases
Browse files Browse the repository at this point in the history
  • Loading branch information
ntsekouras committed Jan 5, 2023
1 parent 2a413f7 commit 612310a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

### Bug Fix

- `Placeholder`: fix label icon right margin when using dashicons ([46918](https://github.com/WordPress/gutenberg/pull/46918)).
- `Placeholder`: set fixed right margin for label's icon ([46918](https://github.com/WordPress/gutenberg/pull/46918)).

## 23.1.0 (2023-01-02)

Expand Down
6 changes: 1 addition & 5 deletions packages/components/src/placeholder/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
> svg,
.dashicon,
.block-editor-block-icon {
margin-right: 1ch;
margin-right: $grid-unit-15;
fill: currentColor;
// Optimizate for high contrast modes.
// See also https://blogs.windows.com/msedgedev/2020/09/17/styling-for-windows-high-contrast-with-new-standards-for-forced-colors/.
Expand All @@ -54,10 +54,6 @@
}
}

.dashicon {
margin-right: 0.7em;
}

// Don't take up space if the label is empty.
&:empty {
display: none;
Expand Down

0 comments on commit 612310a

Please sign in to comment.