Navigation: Fix submenus not showing on click. (#35716)

WordPress · Oct 18, 2021 · 4cce582 · 4cce582
1 parent 07eb9a1
commit 4cce582
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/packages/block-library/src/navigation-submenu/editor.scss b/packages/block-library/src/navigation-submenu/editor.scss
@@ -17,7 +17,7 @@
 			width: auto !important;
 			// These styles are needed to display the dropdown properly when it is empty.
 			position: absolute;
-			left: -1em;
+			left: -1px; // Border width.
 			top: 100%;
 
 			@include break-medium {

diff --git a/packages/block-library/src/navigation/style.scss b/packages/block-library/src/navigation/style.scss
@@ -121,11 +121,10 @@
 		// Don't take up space when the menu is collapsed.
 		width: 0;
 		height: 0;
-		overflow: hidden;
 
 		// Submenu items.
 		> .wp-block-navigation-item {
-			> a {
+			> .wp-block-navigation-item__content {
 				display: flex;
 				flex-grow: 1;
 
@@ -142,12 +141,12 @@
 		}
 
 		// Spacing in all submenus.
-		a {
+		.wp-block-navigation-item__content {
 			margin: 0;
 		}
 
 		// Submenu indentation when there's no background.
-		left: -1em;
+		left: -1px; // Border width.
 		top: 100%;
 
 		// Indentation for all submenus.
@@ -184,7 +183,6 @@
 		opacity: 1;
 		width: auto;
 		height: auto;
-		overflow: initial;
 		min-width: 200px;
 	}
 
@@ -253,7 +251,7 @@
 // https://css-tricks.com/almanac/selectors/w/where/
 
 // Set the default menu item padding to zero, to allow text-only buttons.
-.wp-block-navigation a {
+.wp-block-navigation .wp-block-navigation-item__content {
 	padding: 0;
 }
 
@@ -264,7 +262,7 @@
 }
 
 // Provide a default padding for submenus who should always have some, regardless of the top level menu items.
-.wp-block-navigation :where(.wp-block-navigation__submenu-container) a {
+.wp-block-navigation :where(.wp-block-navigation__submenu-container) .wp-block-navigation-item__content {
 	padding: 0.5em 1em;
 }