Skip to content

Commit

Permalink
Reverting back to Space key since we've added a keyboard event for Sp…
Browse files Browse the repository at this point in the history
…ace.

Reinstate tabIndex
  • Loading branch information
ramonjd committed Nov 17, 2021
1 parent 4099726 commit 48e288c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ function ListViewBlockSelectButton(
position,
siblingBlockCount,
level,
tabIndex,
onFocus,
onDragStart,
onDragEnd,
Expand Down Expand Up @@ -74,7 +75,7 @@ function ListViewBlockSelectButton(
onKeyDown={ onKeyDownHandler }
aria-describedby={ descriptionId }
ref={ ref }
tabIndex="0"
tabIndex={ tabIndex }
onFocus={ onFocus }
onDragStart={ onDragStartHandler }
onDragEnd={ onDragEnd }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ describe( 'Navigating the block hierarchy', () => {
// Return to first block.
await openListViewSidebar();
await page.keyboard.press( 'ArrowUp' );
await page.keyboard.press( 'Enter' );
await page.keyboard.press( 'Space' );

// Replace its content.
await pressKeyWithModifier( 'primary', 'a' );
Expand Down

0 comments on commit 48e288c

Please sign in to comment.