Fix: Display HTML in titles of latest posts block. (#13622)

WordPress · Mar 6, 2019 · 3ca7834 · 3ca7834
1 parent 03749b3
commit 3ca7834
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 13 deletions.
diff --git a/packages/block-library/src/latest-posts/edit.js b/packages/block-library/src/latest-posts/edit.js
@@ -7,7 +7,11 @@ import classnames from 'classnames';
 /**
  * WordPress dependencies
  */
-import { Component, Fragment } from '@wordpress/element';
+import {
+	Component,
+	Fragment,
+	RawHTML,
+} from '@wordpress/element';
 import {
 	PanelBody,
 	Placeholder,
@@ -21,7 +25,6 @@ import apiFetch from '@wordpress/api-fetch';
 import { addQueryArgs } from '@wordpress/url';
 import { __ } from '@wordpress/i18n';
 import { dateI18n, format, __experimentalGetSettings } from '@wordpress/date';
-import { decodeEntities } from '@wordpress/html-entities';
 import {
 	InspectorControls,
 	BlockAlignmentToolbar,
@@ -171,16 +174,27 @@ class LatestPostsEdit extends Component {
 						[ `columns-${ columns }` ]: postLayout === 'grid',
 					} ) }
 				>
-					{ displayPosts.map( ( post, i ) =>
-						<li key={ i }>
-							<a href={ post.link } target="_blank">{ decodeEntities( post.title.rendered.trim() ) || __( '(Untitled)' ) }</a>
-							{ displayPostDate && post.date_gmt &&
-								<time dateTime={ format( 'c', post.date_gmt ) } className="wp-block-latest-posts__post-date">
-									{ dateI18n( dateFormat, post.date_gmt ) }
-								</time>
-							}
-						</li>
-					) }
+					{ displayPosts.map( ( post, i ) => {
+						const titleTrimmed = post.title.rendered.trim();
+						return (
+							<li key={ i }>
+								<a href={ post.link } target="_blank">
+									{ titleTrimmed ? (
+										<RawHTML>
+											{ titleTrimmed }
+										</RawHTML>
+									) :
+										__( '(Untitled)' )
+									}
+								</a>
+								{ displayPostDate && post.date_gmt &&
+									<time dateTime={ format( 'c', post.date_gmt ) } className="wp-block-latest-posts__post-date">
+										{ dateI18n( dateFormat, post.date_gmt ) }
+									</time>
+								}
+							</li>
+						);
+					} ) }
 				</ul>
 			</Fragment>
 		);

diff --git a/packages/block-library/src/latest-posts/index.php b/packages/block-library/src/latest-posts/index.php
@@ -37,7 +37,7 @@ function render_block_core_latest_posts( $attributes ) {
 		$list_items_markup .= sprintf(
 			'<li><a href="%1$s">%2$s</a>',
 			esc_url( get_permalink( $post ) ),
-			esc_html( $title )
+			$title
 		);
 
 		if ( isset( $attributes['displayPostDate'] ) && $attributes['displayPostDate'] ) {