Skip to content

Commit

Permalink
LinkControl: fix scrollbar displayed on toggle link settings (#47986)
Browse files Browse the repository at this point in the history
* Link control: fix scrollbar displayed on toggle

* Update changelog

* Add comment

* Fix comment url
  • Loading branch information
t-hamano authored Feb 15, 2023
1 parent 58cd891 commit 3bcfbfe
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
4 changes: 4 additions & 0 deletions packages/block-editor/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug Fix

- `LinkControl`: fix scrollbar displayed on toggle link settings ([#47986](https://github.com/WordPress/gutenberg/pull/47986)).

## 11.3.0 (2023-02-01)

## 11.2.0 (2023-01-11)
Expand Down
8 changes: 7 additions & 1 deletion packages/block-editor/src/components/link-control/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,13 @@ $preview-image-height: 140px;
justify-content: space-between;
margin: 0;
padding: $grid-unit-20;
padding-top: 0;

// To hide the horizontal scrollbar on toggle.
// Margin and padding are needed to prevent cutoff of the toggle button focus outline.
// See: https://github.com/WordPress/gutenberg/pull/47986
margin-top: calc(var(--wp-admin-border-width-focus) * -1);
padding-top: var(--wp-admin-border-width-focus);
overflow: hidden;
}

.block-editor-link-control__unlink {
Expand Down

1 comment on commit 3bcfbfe

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 3bcfbfe.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4183521757
📝 Reported issues:

Please sign in to comment.