Skip to content

Commit

Permalink
Components: refactor useFlex to pass exhaustive-deps (#45528)
Browse files Browse the repository at this point in the history
  • Loading branch information
chad1008 authored Nov 9, 2022
1 parent dc7a241 commit 2d63b15
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
### Internal

- `PaletteEditListView`: Update to ignore `exhaustive-deps` eslint rule ([#45467](https://github.com/WordPress/gutenberg/pull/45467)).
- `Flex`: Update to pass `exhaustive-deps` eslint rule ([#45528](https://github.com/WordPress/gutenberg/pull/45528)).
- `withNotices`: Update to pass `exhaustive-deps` eslint rule ([#45530](https://github.com/WordPress/gutenberg/pull/45530)).
- `ItemGroup`: Update to pass `exhaustive-deps` eslint rule ([#45531](https://github.com/WordPress/gutenberg/pull/45531)).

Expand Down
3 changes: 0 additions & 3 deletions packages/components/src/flex/flex/hook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ export function useFlex( props: WordPressComponentProps< FlexProps, 'div' > ) {

const isColumn =
typeof direction === 'string' && !! direction.includes( 'column' );
const isReverse =
typeof direction === 'string' && direction.includes( 'reverse' );

const cx = useCx();

Expand Down Expand Up @@ -87,7 +85,6 @@ export function useFlex( props: WordPressComponentProps< FlexProps, 'div' > ) {
expanded,
gap,
isColumn,
isReverse,
justify,
wrap,
] );
Expand Down

0 comments on commit 2d63b15

Please sign in to comment.