Skip to content

Commit

Permalink
Repository Management: PRs should be milestoned to the release they l…
Browse files Browse the repository at this point in the history
…anded in (#5887)
  • Loading branch information
danielbachhuber authored and pento committed Apr 3, 2018
1 parent fffe00e commit 25a0e7a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/repository-management.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ A pull request can generally be merged once it is:

The final pull request merge decision is made by the **@wordpress/gutenberg-core** team.

Please make sure to assign your merged pull request to its release milestone. Doing so creates the historical legacy of what code landed when, and makes it possible for all project contributors (even non-technical ones) to access this information.

### Closing Pull Requests

Sometimes, a pull request may not be mergeable, no matter how much additional effort is applied to it (e.g. out of scope). In these cases, it’s best to communicate with the contributor graciously while describing why the pull request was closed, this encourages productive future involvement.
Expand Down

0 comments on commit 25a0e7a

Please sign in to comment.