Lodash: Remove completely from docgen package (#43100)

WordPress · Aug 10, 2022 · 23d1d84 · 23d1d84
1 parent 9881502
commit 23d1d84
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/docgen/lib/get-export-entries.js b/packages/docgen/lib/get-export-entries.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-const { get } = require( 'lodash' );
-
 /**
  * Returns the export entry records of the given export statement.
  * Unlike [the standard](http://www.ecma-international.org/ecma-262/9.0/#exportentry-record),
@@ -31,7 +26,7 @@ module.exports = ( token ) => {
 					name = t.declaration.left.name;
 					break;
 				default:
-					name = get( t.declaration, [ 'id', 'name' ], '*default*' );
+					name = t.declaration.id?.name ?? '*default*';
 			}
 			return name;
 		};
@@ -64,7 +59,7 @@ module.exports = ( token ) => {
 			name.push( {
 				localName: specifier.local.name,
 				exportName: specifier.exported.name,
-				module: get( token.source, [ 'value' ], null ),
+				module: token.source?.value ?? null,
 				lineStart: specifier.loc.start.line,
 				lineEnd: specifier.loc.end.line,
 			} )

diff --git a/packages/docgen/lib/get-intermediate-representation.js b/packages/docgen/lib/get-intermediate-representation.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-const { get } = require( 'lodash' );
-
 /**
  * Internal dependencies
  */
@@ -154,8 +149,8 @@ module.exports = (
 			ir.push( {
 				path,
 				name: entry.exportName,
-				description: get( doc, [ 'description' ], UNDOCUMENTED ),
-				tags: get( doc, [ 'tags' ], [] ),
+				description: doc?.description ?? UNDOCUMENTED,
+				tags: doc?.tags ?? [],
 				lineStart: entry.lineStart,
 				lineEnd: entry.lineEnd,
 			} );

diff --git a/packages/docgen/lib/get-leading-comments.js b/packages/docgen/lib/get-leading-comments.js
@@ -1,8 +1,3 @@
-/**
- * External dependencies
- */
-const { last } = require( 'lodash' );
-
 /**
  * Function that returns the leading comment
  * of a Espree node.
@@ -14,7 +9,10 @@ const { last } = require( 'lodash' );
 module.exports = ( declaration ) => {
 	let comments;
 	if ( declaration.leadingComments ) {
-		const lastComment = last( declaration.leadingComments );
+		const lastComment =
+			declaration.leadingComments[
+				declaration.leadingComments.length - 1
+			];
 		if ( lastComment ) {
 			comments = lastComment.value;
 		}

diff --git a/packages/docgen/lib/index.js b/packages/docgen/lib/index.js
@@ -3,7 +3,6 @@
  */
 const fs = require( 'fs' );
 const path = require( 'path' );
-const { last } = require( 'lodash' );
 
 /**
  * Internal dependencies
@@ -60,7 +59,10 @@ const processFile = ( rootDir, inputFile ) => {
 		const result = engine(
 			relativePath,
 			data,
-			getIRFromRelativePath( rootDir, last( currentFileStack ) )
+			getIRFromRelativePath(
+				rootDir,
+				currentFileStack[ currentFileStack.length - 1 ]
+			)
 		);
 		currentFileStack.pop();
 		return result;

diff --git a/packages/docgen/package.json b/packages/docgen/package.json
@@ -29,7 +29,6 @@
 	"dependencies": {
 		"@babel/core": "^7.16.0",
 		"comment-parser": "^1.1.1",
-		"lodash": "^4.17.21",
 		"mdast-util-inject": "1.1.0",
 		"optionator": "0.8.2",
 		"remark": "10.0.1",