Restore span for search block

WordPress · Mar 25, 2021 · 2385eff · 2385eff
1 parent 595aba1
commit 2385eff
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/packages/block-library/src/search/edit.js b/packages/block-library/src/search/edit.js
@@ -149,19 +149,21 @@ export default function SearchEdit( {
 				) }
 
 				{ ! buttonUseIcon && (
-					<RichText
-						type="submit"
-						className="wp-block-search__button"
-						tagName="button"
-						style={ { display: 'inline-block' } }
-						aria-label={ __( 'Button text' ) }
-						placeholder={ __( 'Add button text…' ) }
-						withoutInteractiveFormatting
-						value={ buttonText }
-						onChange={ ( html ) =>
-							setAttributes( { buttonText: html } )
-						}
-					/>
+					// This rule only makes sense for UI not blocks.
+					// eslint-disable-next-line react/forbid-elements
+					<button type="submit" className="wp-block-search__button">
+						<RichText
+							tagName="span"
+							style={ { display: 'inline-block' } }
+							aria-label={ __( 'Button text' ) }
+							placeholder={ __( 'Add button text…' ) }
+							withoutInteractiveFormatting
+							value={ buttonText }
+							onChange={ ( html ) =>
+								setAttributes( { buttonText: html } )
+							}
+						/>
+					</button>
 				) }
 			</>
 		);