Skip to content

Commit

Permalink
Show right chevrons for blocks that can be drilled into
Browse files Browse the repository at this point in the history
  • Loading branch information
talldan committed Apr 24, 2024
1 parent e5de56a commit 181fa47
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 3 deletions.
11 changes: 10 additions & 1 deletion packages/block-editor/src/components/block-inspector/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { useSelect } from '@wordpress/data';
/**
* Internal dependencies
*/
import { unlock } from '../../lock-unlock';
import SkipToSelectedBlock from '../skip-to-selected-block';
import BlockCard from '../block-card';
import MultiSelectionInspector, {
Expand Down Expand Up @@ -77,6 +78,11 @@ function BlockInspectorContentLockedParent( { clientId } ) {
[ clientId ]
);
const blockInformation = useBlockDisplayInformation( clientId );
const contentClientIdsWithControls = useSelect(
( select ) =>
unlock( select( blockEditorStore ) ).getContentOnlyControlsBlocks(),
[]
);
return (
<div className="block-editor-block-inspector">
<BlockCard
Expand All @@ -87,7 +93,10 @@ function BlockInspectorContentLockedParent( { clientId } ) {
<BlockInfo.Slot />
{ contentClientIds.length > 0 && (
<PanelBody title={ __( 'Content' ) }>
<BlockQuickNavigation clientIds={ contentClientIds } />
<BlockQuickNavigation
clientIds={ contentClientIds }
clientIdsWithControls={ contentClientIdsWithControls }
/>
</PanelBody>
) }
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,24 @@ import {
Flex,
FlexBlock,
FlexItem,
Icon,
} from '@wordpress/components';
import {
__experimentalGetBlockLabel,
store as blocksStore,
} from '@wordpress/blocks';
import { chevronRight } from '@wordpress/icons';

/**
* Internal dependencies
*/
import { store as blockEditorStore } from '../../store';
import BlockIcon from '../block-icon';

export default function BlockQuickNavigation( { clientIds } ) {
export default function BlockQuickNavigation( {
clientIds,
clientIdsWithControls,
} ) {
if ( ! clientIds.length ) {
return null;
}
Expand All @@ -31,13 +36,14 @@ export default function BlockQuickNavigation( { clientIds } ) {
<BlockQuickNavigationItem
key={ clientId }
clientId={ clientId }
hasControls={ clientIdsWithControls.includes( clientId ) }
/>
) ) }
</VStack>
);
}

function BlockQuickNavigationItem( { clientId } ) {
function BlockQuickNavigationItem( { clientId, hasControls } ) {
const { name, icon, isSelected } = useSelect(
( select ) => {
const {
Expand Down Expand Up @@ -81,6 +87,11 @@ function BlockQuickNavigationItem( { clientId } ) {
<FlexBlock style={ { textAlign: 'left' } }>
<Truncate>{ name }</Truncate>
</FlexBlock>
{ hasControls && (
<FlexItem>
<Icon icon={ chevronRight } />
</FlexItem>
) }
</Flex>
</Button>
);
Expand Down

0 comments on commit 181fa47

Please sign in to comment.