Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Add new icons for embeds, and default block #238

Closed
wants to merge 4 commits into from
Closed

Conversation

jasmussen
Copy link
Collaborator

@jasmussen jasmussen commented Oct 13, 2017

This fixes #203

This PR adds a generic "block" icon, necessary for Gutenberg

In addition to this, it adds a generic "embed" block, as well as a few other topical embed blocks:

  • post embed
  • audio embed
  • photo embed
  • video embed

Note, these icons are placed in the "Gutenberg" directory, which means it does not get added to the icon font.

Screenshots:

screen shot 2017-10-13 at 10 58 09

screen shot 2017-10-13 at 11 26 36

screen shot 2017-10-13 at 11 26 42

screen shot 2017-10-13 at 11 26 46

screen shot 2017-10-13 at 11 26 51

screen shot 2017-10-13 at 11 27 03

screen shot 2017-10-13 at 11 30 37

This fixes #203

This PR adds a generic "block" icon, necessary for Gutenberg

In addition to this, it adds a generic "embed" block, as well as a few other topical embed blocks:

- post embed
- audio embed
- photo embed
- video embed
@folletto
Copy link
Collaborator

What I feel works well:

  1. The shape and structure
  2. The way it locks together type icon and embed icon

What I find not ideal:

  1. Video having a different structure and locking
  2. Embed generic using the "code" icon, and being different

My advice would be to have the same identical baseline, and reuse it.

This is a crappy mock of what I mean (especially crappy for video):

screen shot 2017-10-13 at 12 36 34

@field2
Copy link
Contributor

field2 commented Oct 13, 2017

I see what @folletto is saying, and I think it's right. They're a good representation of blocks of code, but should be more consistent–the brackets should be the same size and place, and the "sub-icon" should be reversed out like in audio and post. Having no "sub-icon" in generic is fine. Photo should be enclosed; the subicon shouldn't share a border with the main icon. The video subicon should be enclosed and white.

@jasmussen
Copy link
Collaborator Author

Solid, solid feedback. Will address it monday! Thanks all!

@field2
Copy link
Contributor

field2 commented Oct 13, 2017

screen shot 2017-10-13 at 10 17 47 am

screen shot 2017-10-13 at 10 17 28 am

Sorry for the cruddy screenshots, but here's a suggestion for unifying the look of these. They're 18px wide now, so it's hard to say if they'd look weird with the other gutenberg embed icons.

@jasmussen
Copy link
Collaborator Author

I dig every one of those, Ben, except the generic one. It feels like the generic one would actually work better without the asterisk — I understand why you did this, but after seeing Davide's empty one I was like, yeah, that works.

@jaymanpandya
Copy link

+1 on @jasmussen for the generic icon. 😊 they look awesome. 😍

@field2
Copy link
Contributor

field2 commented Oct 13, 2017

I actually did a generic one without asterisk, but forgot to post. Yep, it's better without it.

@jasmussen
Copy link
Collaborator Author

Solid! Ben, feel free to add your updated SVG files to this branch, overwrite mine. Okay to push. I can grunt/build and rebase if need be. Thanks for the help.

jasmussen pushed a commit that referenced this pull request Oct 16, 2017
This PR replaces #238, as that one got messy.
@jasmussen
Copy link
Collaborator Author

This branch got a little messy, so I created a new one and merged your icons with the permission given in Slack.

@jasmussen jasmussen closed this Oct 16, 2017
@jasmussen jasmussen deleted the add/new-icons branch October 16, 2017 08:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed Icons: New icons for different types of embeds
4 participants