Skip to content

Commit

Permalink
apply changes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
reimic committed Mar 2, 2024
1 parent bb4ae8f commit ae4256f
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 10 deletions.
2 changes: 1 addition & 1 deletion php.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ error_reporting=-1
log_errors_max_len=0
zend.assertions=1
assert.exception=1
xdebug.show_exception_trace=0
xdebug.show_exception_trace=0
2 changes: 1 addition & 1 deletion phpunit.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@
<directory>tests</directory>
</testsuite>
</testsuites>
</phpunit>
</phpunit>
5 changes: 4 additions & 1 deletion src/WordPress/Blueprints/BlueprintException.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

namespace WordPress\Blueprints;

class BlueprintException extends \Exception {
use Exception;

class BlueprintException extends Exception
{

}
4 changes: 2 additions & 2 deletions src/WordPress/Blueprints/Runner/Step/RmStepRunner.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
use WordPress\Blueprints\BlueprintException;
use WordPress\Blueprints\Model\DataClass\RmStep;


class RmStepRunner extends BaseStepRunner
{
/**
* @param RmStep $input
*/
function run(RmStep $input) {
public function run(RmStep $input)
{
$resolvedPath = $this->getRuntime()->resolvePath($input->path);
$fileSystem = new Filesystem();
if (false === $fileSystem->exists($resolvedPath)) {
Expand Down
10 changes: 5 additions & 5 deletions src/WordPress/Blueprints/Runner/Step/StepRunnerInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
use WordPress\Blueprints\Resources\ResourceManager;
use WordPress\Blueprints\Runtime\RuntimeInterface;

interface StepRunnerInterface {
interface StepRunnerInterface
{

function setResourceManager( ResourceManager $map );
public function setResourceManager(ResourceManager $map);

function setRuntime( RuntimeInterface $runtime ): void;
public function setRuntime(RuntimeInterface $runtime): void;

// @TODO: Document how this method isn't defined because
// PHP doens't support covariant arguments
// function run( StepInterface $input, Tracker $tracker );

// function run( StepInterface $input, Tracker $tracker );
}

0 comments on commit ae4256f

Please sign in to comment.