This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
changed the title
SSR: Add basic wp-each test coverage
SSR: Try implementing Mar 1, 2023
wp-each
ockham
force-pushed
the
add/wp-each-ssr
branch
2 times, most recently
from
March 2, 2023 10:24
8cfb8a6
to
f227d61
Compare
2 tasks
ockham
changed the base branch from
add/directive-processor
to
add/directive-processor-and-unit-tests
March 9, 2023 16:02
Base automatically changed from
add/directive-processor-and-unit-tests
to
main-wp-directives-plugin
March 15, 2023 14:18
I'm going to close this issue as part of the migration to the Gutenberg repository. This task was added to the Roadmap and we'll open a new issue/discussion once it's time to start working on this again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using
add/directive-processor
from #158 as its base branch, in order to have access to theWP_Directive_Processor
helper class, whoseset_inner_html
andget_inner_html
methods this PR needs.WIP. Based on a pair programming session with @luisherranz earlier today.