FileSystemWritesDisallow: Use the WPCS abstract function call sniff #800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were three sniffs which still extended the upstream
Generic_Sniffs_PHP_ForbiddenFunctionsSniff
class.Extending the
WordPress_AbstractFunctionRestrictionsSniff
instead has the following advantages:exclude
property to selectively exclude groups becomes available.public $forbiddenFunctions
property which could be overruled via the ruleset.WordPress_AbstractFunctionRestrictionsSniff
, the sniffs will benefit from the additional detection. (see Restricted functions used in callbacks #611)WordPress_Sniff
class are available for use.This PR addresses the above for the
VIP.FileSystemWritesDisallow
sniff.This PR contains no significant functional changes. The sniff effectively still does the same.
Notes:
FileWriteDetected
.Related to #614