Add strict type checking for array_search() and array_keys(). #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will only check for the `$strict` parameter for `array_keys()` if the second parameter has been set. Fixes #503. The file/sniff name is now a bit dated as the sniff checks for more than just `in_array()`, but changing the file/sniff/classname would break backward compatibility. What do you think ?
Yeah, we'll just leave it like it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will only check for the
$strictparameter forarray_keys()if the second parameter has been set.Fixes #503.
The file/sniff name is now a bit dated as the sniff checks for more than just
in_array(), but changing the file/sniff/classname would break backward compatibility.What do you think ?