Add sniff for Restricted Database Classes. #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2016
jrfnl
force-pushed
the
WPCS/feature/no-direct-db-class-calls
branch
from
fd81aaa to
0cf39c1
Compare
|
Rebased for merge conflict (also done for the others which were conflicting) |
* Add `AbstractClassRestrictionsSniff` which can sniff for the use of (namespaced) classes. The abstract class does currently not support `use` statement aliased namespaces. * Refactored the `AbstractFunctionRestrictionsSniff` somewhat to make parts more reusable and extended the `AbstractClassRestrictionsSniff` from this class. * This refactoring includes a small efficiency improvement where the function regular expressions are no longer rebuild for every token, but only build once. * Add `DB/RestrictedClassesSniff` to actually sniff for the Restricted DB Classes. * Added extensive unit tests which test both the `DB/RestrictedClassesSniff` as well as the complete functionality of the Abstract class. If at some point in the future the `AbstractFunctionRestrictionsSniff` would need to support namespaces too, this will not be too hard to do. Some functions would need to be moved from the `AbstractClassRestrictionsSniff` to the `AbstractFunctionRestrictionsSniff` and the the functionname determination would need to start using them, but the underlying logic has already been build.
jrfnl
force-pushed
the
WPCS/feature/no-direct-db-class-calls
branch
from
0cf39c1 to
3b9ae92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractClassRestrictionsSniffclass which can sniff for the use of (namespaced) classes. The abstract class does currently not supportusestatement aliased namespaces.AbstractFunctionRestrictionsSniffsomewhat to make parts more reusable and extended theAbstractClassRestrictionsSnifffrom this class.DB/RestrictedClassesSniffto actually sniff for the Restricted DB Classes.DB/RestrictedClassesSniffas well as the complete functionality of the Abstract class.If at some point in the future the
AbstractFunctionRestrictionsSniffwould need to support namespaces too, this will not be too hard to do. Some functions would need to be moved from theAbstractClassRestrictionsSniffto theAbstractFunctionRestrictionsSniffand the functionname determination would need to start using them, but the underlying logic has already been build.This is the sister-PR to #612 which covers the function sniffing for direct DB calls.