Fix bug in function name comparison. #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
WPCS/feature/case-insensitive-function-name-compare
branch
from
0b29cff to
4a527b9
Compare
AbstractFunctionRestrictionsSniff did not allow for case-insensitive comparison of function names. > **Note**: Function names are case-insensitive, though it is usually good form to call functions as they appear in their declaration. Ref: http://php.net/manual/en/functions.user-defined.php Also: * Better be safe than sorry, so `preg_quote()`-ing the function names passed to this class. * Minor memory management improvement: no need to remember the matched function name.
|
Interesting. I just found another bug in this class which I had apparently accidentally fixed as well. The wildcard replacement was not just replacing the Example of the effect of the bug: Added unit test to that effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractFunctionRestrictionsSniffdid not allow for case-insensitive comparison of function names.Ref: http://php.net/manual/en/functions.user-defined.php
Also:
preg_quote()-ing the function names passed to this class.The first commit adds a unit test proving the bug. The second commit fixes the bug.