Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev-lib and use for dogfooding rulesets (WordPress-Core) in Travis CI builds #587

Closed
wants to merge 1 commit into from

Conversation

westonruter
Copy link
Member

Fixes #256.

@JDGrimes
Copy link
Contributor

This appears to be failing on HHVM: https://travis-ci.org/WordPress-Coding-Standards/WordPress-Coding-Standards/jobs/143952804

develop doesn't currently fail on HHVM, so that would be a regression.

@westonruter
Copy link
Member Author

Humm. It seems to be failing during the install step but it doesn't indicate what the failure is. I'm not sure actually if dev-lib has run on the HHVM environment yet.

@GaryJones
Copy link
Member

Can you please summarise what this change is doing?

@westonruter
Copy link
Member Author

It's just using wp-dev-lib's builtin PHP syntax check and PHPCS running. The key feature of wp-dev-lib here is the ability to restrict error reporting to the changes in a PR. However, with #590 it is not necessary since the whole codebase is now getting cleaned.

@ntwb
Copy link
Member

ntwb commented Jul 13, 2016

develop doesn't currently fail on HHVM, so that would be a regression.

Things might be different after #595 which updates the HHVM job to use the latest HHVM

@JDGrimes JDGrimes closed this Jul 14, 2016
@JDGrimes
Copy link
Contributor

@westonruter Feel free to open another PR if you want to still use the dev-lib for syntax checking, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants