Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for catching functions that will be deprecated once php7 updates #571

Merged
merged 1 commit into from
Jun 11, 2016
Merged

Conversation

alexiskulash
Copy link
Contributor

Functions include ereg, eregi, ereg_replace, and split

@alexiskulash
Copy link
Contributor Author

cc @sboisvert

@westonruter
Copy link
Member

Are these deprecated functions restricted by VIP?

@sboisvert
Copy link
Contributor

Yup we just finished removing them from all the repos. I'll add it to the documentation early next week.

@westonruter westonruter merged commit e291b02 into WordPress:develop Jun 11, 2016
@jrfnl
Copy link
Member

jrfnl commented Jun 11, 2016

This PR raises two questions for me:

  1. Should cross-PHP version compatibility issues be a concern which should be addressed by WPCS ?
  2. And if so, wouldn't it make more sense to incorporate the far more comprehensive PHP Compatibility sniffs rather than reinvent the wheel ?

@sboisvert
Copy link
Contributor

sboisvert commented Jun 12, 2016

  1. Should cross-PHP version compatibility issues be a concern which should be addressed by WPCS ?

I can't speak for the project as a whole but VIP is moving to requiring PHP7 compatibility, these functions are the ones we've seen used multiple times so it was a sort of quick win.

  1. And if so, wouldn't it make more sense to incorporate the far more comprehensive PHP Compatibility sniffs rather than reinvent the wheel ?

If the project's answer to 1 is yes then I would agree with 2.

@jrfnl jrfnl added this to the 0.10.0 milestone Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants