Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10.0 #565

Merged
merged 186 commits into from
Aug 29, 2016
Merged
Changes from 2 commits
Commits
Show all changes
186 commits
Select commit Hold shift + click to select a range
242c05f
Ensure translatable strings, and string domains are not dynamic, fixe…
shadyvb Dec 12, 2013
073620e
Merge branch 'develop' into issue-50
westonruter Oct 11, 2014
94c0030
Add Atom Linter instructions to README
corysimmons Feb 2, 2016
cabd7cc
Merge pull request #520 from corysimmons/patch-1
JDGrimes Feb 2, 2016
e4b706e
Add whitelisting comment for tax query
wesm87 Feb 5, 2016
20df378
Updated unit test to check whitelisting comment.
wesm87 Feb 5, 2016
b44d7b3
Updated unit test with new expected warning line
wesm87 Feb 5, 2016
2a44d8c
Merge pull request #524 from wesm87/479-tax-query-whitelisting-comment
westonruter Feb 5, 2016
a996a0a
Remove extra right paren from unit test
westonruter Feb 5, 2016
95dd49e
Note about some issues coming from upstream
JDGrimes Feb 5, 2016
7cc95d6
Merge pull request #526 from WordPress-Coding-Standards/JDGrimes-patch-1
westonruter Feb 6, 2016
882ff3a
Update README.md
corysimmons Feb 10, 2016
abc08ac
Merge pull request #528 from corysimmons/patch-1
westonruter Feb 10, 2016
1be8127
Use ConcatenationSpacing rule.
samwilson Mar 9, 2016
35d4359
Merge pull request #536 from samwilson/concat
westonruter Mar 9, 2016
ab1075b
Merge branch 'develop' of https://github.com/WordPress-Coding-Standar…
westonruter Mar 14, 2016
0fc4f46
Add unit tests from @GaryJones; use WP coding standards
westonruter Mar 14, 2016
d02511e
Add WordPress.WP.I18n to WordPres-Extra
westonruter Mar 14, 2016
022444a
Improve checks for interpolated vars
westonruter Mar 14, 2016
6f21e41
Add intentionally-failing tests for _n() functions
westonruter Mar 14, 2016
baa4b9e
Implement translation function-specific arg checking
westonruter Mar 15, 2016
3f2c695
Warn against using translate() and translate_with_gettext_context()
westonruter Mar 15, 2016
eada3e7
Forbid using single-underscore _()
westonruter Mar 15, 2016
f2312fa
Fix some coding style and spelling
westonruter Mar 15, 2016
9ebd183
Let i18n function types be defined in array
westonruter Mar 18, 2016
375bb1f
Include PSR2.ControlStructures.ElseIfDeclaration in WordPress-Core
ocean90 Mar 20, 2016
6439620
Merge pull request #544 from ocean90/issue-543
westonruter Mar 21, 2016
a47029e
Refactor methods to reduce duplication; add too-many-args check
westonruter Mar 23, 2016
8c92bdf
Merge pull request #136 from WordPress-Coding-Standards/issue-50
JDGrimes Mar 23, 2016
c459f67
Merge multi-line string literal tokens into single token
westonruter Mar 24, 2016
5200868
Merge pull request #545 from WordPress-Coding-Standards/bugfix/i18n-m…
westonruter Mar 27, 2016
684bb8d
Honor whitelisted_mixed_case_member_var_names for variables (NotSnake…
westonruter Apr 1, 2016
bd5109c
Include cat_ID among whitelisted var names for ValidVariableName
westonruter Apr 1, 2016
cbf7391
Ignore Squiz.Commenting.FunctionComment.ScalarTypeHintMissing
westonruter Apr 1, 2016
4753fb1
Revert "Honor whitelisted_mixed_case_member_var_names for variables (…
westonruter Apr 1, 2016
d8d7942
Improve error message for NotSnakeCaseMemberVar to indicate object pr…
westonruter Apr 1, 2016
623040e
Add test case to show variable use of cat_ID is bad, but object var ok
westonruter Apr 1, 2016
96a3f6a
Merge pull request #551 from WordPress-Coding-Standards/bugfix/cat_ID…
Rarst Apr 1, 2016
c1af3a9
Move ScalarTypeHintMissing exclude from WordPress-Core to WordPress-Docs
westonruter Apr 1, 2016
69468d9
Merge pull request #552 from WordPress-Coding-Standards/feature/ignor…
Rarst Apr 1, 2016
139155b
Fix type docs description in /Tests/WhiteSpace/CastStructureSpacingUn…
ntwb Apr 7, 2016
2f4bc3d
Merge pull request #553 from ntwb/develop
JDGrimes Apr 7, 2016
949ac89
Fix checks for _nx_noop and _n_noop which lack number args
westonruter Apr 8, 2016
8dfa23e
Fix error where arguments_tokens would miss last token
westonruter Apr 8, 2016
d8ecf5f
[VariableName Sniff] Add ability to add to the whitelisted variables …
jrfnl Apr 11, 2016
79b2170
[VariableName Sniff] Improve error message differentiation in the sniff.
jrfnl Apr 11, 2016
c4dc927
Add placeholders to numeric i18n functions to align with usage
westonruter Apr 20, 2016
5e03d51
Merge pull request #554 from WordPress-Coding-Standards/bugfix/_n-noop
westonruter Apr 20, 2016
173a89a
Introduce WordPress_Sniffs_WP_I18nSniff::$text_domain property
westonruter Apr 26, 2016
d21367b
Add WordPress.WP.I18n to WordPress-Core
westonruter Apr 26, 2016
0eabc71
Allow `translators:` comments.
jrfnl May 2, 2016
caf19ca
Merge pull request #562 from jrfnl/feature/fix-overzealous-doc-sniff
westonruter May 2, 2016
6749e4e
Merge branch 'master' into develop
westonruter May 2, 2016
ec69684
Merge pull request #560 from WordPress-Coding-Standards/feature/i18n-…
westonruter May 2, 2016
e7707b2
Update with latest VIP checks
sboisvert May 3, 2016
ec2eddc
Merge pull request #563 from sboisvert/patch-1
westonruter May 3, 2016
3eb1faa
Allow 'posts_per_page' of up to 100 on VIP
dlh01 May 9, 2016
4568e4b
Merge pull request #564 from dlh01/vip-posts-per-page
westonruter May 10, 2016
b7b615c
Add rule to check that multiple placeholders are ordered
Jun 8, 2016
0523c41
Pull out content once in check_argument_tokens()
Jun 8, 2016
c11c6fc
Added support for catching functions that will be deprecated once php…
alexiskulash Jun 11, 2016
e291b02
Merge pull request #571 from alexiskulash/develop
westonruter Jun 11, 2016
880e2fd
Add fixer for unordered placeholder
Jun 8, 2016
5f45fbd
Add check for mismatched placeholders
Jun 9, 2016
9f88d39
Remove `get_pages()` from uncached functions in WordPress.VIP.Restric…
Jun 13, 2016
aad1ebf
Merge `get_children` group with `get_posts` group
Jun 14, 2016
24cf416
Move sprintf placeholder regexes into WP_I18nSniff class
Jun 15, 2016
888356e
Factor out i18n test that focuses on the string itself
Jun 15, 2016
08aa148
Add WP.I18n.NoEmptyStrings
Jun 15, 2016
bf1725c
Merge pull request #567 from deBhal/develop
GaryJones Jun 22, 2016
3c23ba9
Merge pull request #557 from jrfnl/feature/allow-variable-name-whitel…
JDGrimes Jun 27, 2016
15460b4
Merge pull request #558 from jrfnl/feature/improve-error-differentiation
JDGrimes Jun 28, 2016
cff5cff
Run travis against PHP 7.0 as well.
jrfnl Jul 10, 2016
07bf22a
Sort the list in a better order
grappler Jul 11, 2016
3889b42
Merge pull request #581 from grappler/patch-1
JDGrimes Jul 11, 2016
eed3612
Add runtime_configuration and path disclosure sections to the VIP.Res…
jrfnl Jul 11, 2016
b788b57
Remove get_pages() from unit testing
Jul 11, 2016
0c8c34b
Switch get_children() from error to warning
Jul 11, 2016
6f255e6
Merge pull request #586 from jrfnl/feature/travis-php7
westonruter Jul 11, 2016
97c27b7
Merge pull request #573 from davidpagepsycle/feature/revert-get-pages…
JDGrimes Jul 11, 2016
0a5973a
Merge pull request #584 from jrfnl/feature/issue-460-vip-ini-set
westonruter Jul 11, 2016
d9bf003
Initial setup of automated code style check for the WPCS library itself.
jrfnl Jul 12, 2016
b0e50f9
Code style adjustments for all sniffs to comply with WordPress-Core s…
jrfnl Jul 12, 2016
f986a92
Code style adjustments for all unit tests to comply with WordPress-Co…
jrfnl Jul 12, 2016
d4b4875
Remove commented out code blocks.
jrfnl Jul 12, 2016
5f3bcee
Minor change to get round empty `if()` statement error.
jrfnl Jul 12, 2016
b358c18
Make sure all methods have one line break before and one after.
jrfnl Jul 12, 2016
2e5f8fc
Minor touch-up.
jrfnl Jul 13, 2016
6b64b1d
Documentation fixes.
jrfnl Jul 13, 2016
3b48438
Travis CI: Upgrade the HHVM job to use Ubuntu Trusty, and a more rece…
ntwb Jul 13, 2016
99556d4
Add sniff for (no) closing PHP tag at end of file to `core` ruleset.
jrfnl Jul 14, 2016
a4879d4
Up the minimum PHPCS version to 2.4.0.
jrfnl Jul 12, 2016
e414185
Add sniff to detect lowercase CONSTANT definitions.
jrfnl Jul 14, 2016
77e400c
Merge pull request #590 from jrfnl/WPCS/feature/wpcs-codestyle
JDGrimes Jul 14, 2016
21abfbe
Merge pull request #591 from jrfnl/feature/issue-588-no-php-closing-tag
JDGrimes Jul 14, 2016
057960b
Up the minimum required PHPCS version to 2.6.
jrfnl Jul 14, 2016
f6af70c
Add unit test to reproduce the bug.
jrfnl Jul 14, 2016
eee2279
Fix bug in control structures whitespace sniff triggered on last meth…
jrfnl Jul 14, 2016
d6eceb3
Add PHP syntax check sniff to the `core` ruleset.
jrfnl Jul 14, 2016
9bae89b
Merge pull request #601 from jrfnl/WPCS/feature/add-syntax-check
westonruter Jul 14, 2016
f1bd7a6
Merge pull request #598 from jrfnl/WPCS/feature/uppercase-constants
westonruter Jul 15, 2016
4cb2a26
Merge pull request #600 from jrfnl/WPCS/feature/further-update-phpcs-…
westonruter Jul 15, 2016
a2b0383
Merge pull request #597 from jrfnl/WPCS/feature/fix-bug-last-in-class
westonruter Jul 15, 2016
17bfbbc
Turn the three abstract classes into proper abstracts.
jrfnl Jul 15, 2016
16f148d
Merge pull request #603 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 15, 2016
6028359
Separate out the sniffing for `extract()`.
jrfnl Jul 15, 2016
b379a6c
Enable the unit test.
jrfnl Jul 16, 2016
468d1ac
Add a work-around for the bug until the upstream PR for this has been…
jrfnl Jul 17, 2016
4a527b9
Add unit test for case insensitive function names.
jrfnl Jul 16, 2016
7fc9df6
Add unit test for incorrect wildcard replacement.
jrfnl Jul 17, 2016
993e9d1
Fix bug in function name comparison.
jrfnl Jul 16, 2016
460c8a9
Update WPCS testing procedure
GaryJones Jul 17, 2016
66136c7
Fix codestyle
GaryJones Jul 17, 2016
f19bbab
Merge pull request #604 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 17, 2016
a17b52d
Merge pull request #609 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 17, 2016
930a883
Merge pull request #610 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 17, 2016
fe77bca
Merge pull request #613 from WordPress-Coding-Standards/gj/update-tes…
JDGrimes Jul 17, 2016
8594451
Add new sniff to check whether a hook name is valid.
jrfnl Jul 14, 2016
f163241
Remove the unit test for namespaced functions.
jrfnl Jul 14, 2016
a17879d
Allow for additional word delimiters.
jrfnl Jul 15, 2016
6569cc6
Remove superfluous `break`s.
jrfnl Jul 17, 2016
8ad78ce
Move function name list to `WordPress_Sniff` class.
jrfnl Jul 17, 2016
48c559a
Disallow direct database calls.
jrfnl Jul 17, 2016
fd76f39
Remove the unit test for namespaced functions.
jrfnl Jul 17, 2016
22e427c
Update the readme file.
jrfnl Jul 18, 2016
ba60ba4
Remove redundant sniff.
jrfnl Jul 19, 2016
8184bf6
Fix issue with whitelist comment not being recognized if inline comme…
jrfnl Jul 19, 2016
9e57179
Use PHPCS build in static token arrays.
jrfnl Jul 19, 2016
0a41cd2
Add some more PHP magic constants which can be skipped to the EscapeO…
jrfnl Jul 19, 2016
a61084d
Add two new function to the `$printingFunctions` array.
jrfnl Jul 19, 2016
dc45512
Merge pull request #612 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 19, 2016
9619ca4
Carry over changes made in the original class to the overloaded methods.
jrfnl Jul 19, 2016
350cc25
Remove a block of superfluous code which was no longer needed after t…
jrfnl Jul 19, 2016
55ea310
Fix issue with double underscore prefixed methods in extended classes.
jrfnl Jul 19, 2016
833feea
Polish it off.
jrfnl Jul 19, 2016
1f76327
Merge pull request #599 from jrfnl/WPCS/feature/lowercase-filter-names
JDGrimes Jul 19, 2016
4bba103
Merge pull request #617 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 19, 2016
d1ea177
Merge pull request #619 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 19, 2016
2c6f67f
Merge pull request #620 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 19, 2016
3b9ae92
Add sniff for Restricted Database Classes.
jrfnl Jul 18, 2016
87bf7d6
Merge pull request #622 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 19, 2016
be7951c
Change the list of PHP magic constants to a class property.
jrfnl Jul 19, 2016
b464c75
Merge pull request #616 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 19, 2016
e0283de
Merge pull request #621 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 19, 2016
48d909d
Merge pull request #615 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 19, 2016
f57842b
Add strict type checking for array_search() and array_keys().
jrfnl Jul 19, 2016
e9eeb8a
Fix one error missing identifier.
jrfnl Jul 20, 2016
4498403
Add ability to whitelist specific functions to the `AbstractFunctionR…
jrfnl Jul 20, 2016
961d13c
Add sniff to disallow alternative PHP open tags.
jrfnl Jul 13, 2016
2cdba84
Make alternative openings tags fixable.
jrfnl Jul 14, 2016
be04587
Rename sniff to `DisallowAlternativePHPTags`.
jrfnl Jul 14, 2016
34d436f
Revisit the complete logic of the `DisallowAlternativePHPTags` Sniff.…
jrfnl Jul 22, 2016
8058cff
Merge pull request #625 from WordPress-Coding-Standards/WPCS/feature/…
westonruter Jul 22, 2016
4bf32d1
Merge pull request #623 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 25, 2016
c3cb7c7
Merge pull request #624 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 25, 2016
0a5d6f4
Merge pull request #626 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 25, 2016
6759229
Merge pull request #585 from jrfnl/feature/issue-580-alternative-open…
JDGrimes Jul 25, 2016
3ad591e
Add (new) sniff for class opening brace on same line to `core` ruleset.
jrfnl Jul 13, 2016
fd1f14e
Add "fixed" file for this sniff.
jrfnl Jul 15, 2016
2b38d7e
Give the class opener sniff a more meaningful name.
jrfnl Jul 15, 2016
4ba0cd2
Whitespace can be a pain to commit.
jrfnl Jul 15, 2016
c9aa2eb
Allow for multi-line class declarations.
jrfnl Jul 25, 2016
674c3e9
Prevent WPCS throwing an "undefined offset" notice during live code r…
jrfnl Jul 26, 2016
e01adcb
Merge pull request #636 from WordPress-Coding-Standards/WPCS/feature/…
GaryJones Jul 26, 2016
7721698
Split off POSIX Functions restrictions to its own sniff.
jrfnl Jul 17, 2016
358bc2b
Remove extra tab
JDGrimes Jul 27, 2016
b7ca090
Merge pull request #608 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Jul 27, 2016
9d0d32d
Merge pull request #596 from jrfnl/WPCS/feature/class-brace-same-line
JDGrimes Jul 28, 2016
f4b798e
Order the `core` ruleset according to the handbook.
jrfnl Jul 28, 2016
1d02fcf
Merge pull request #595 from ntwb/patch-1
westonruter Jul 29, 2016
de73645
Consistent class exists check for extended classes.
jrfnl Jul 19, 2016
8760c44
Verify the extended classes
jrfnl Jul 29, 2016
1f21bd8
Merge pull request #645 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Aug 1, 2016
1939480
Merge pull request #647 from WordPress-Coding-Standards/WPCS/feature/…
JDGrimes Aug 1, 2016
f60bfe5
Streamline WPCS in file documentation. (#651)
jrfnl Aug 18, 2016
43d6949
Add some additional relevant information about running the PHPCompati…
jrfnl Aug 25, 2016
94b4858
Merge pull request #669 from WordPress-Coding-Standards/feature/updat…
GaryJones Aug 26, 2016
9a63577
Improve VariableName whitelisting for the `ValidVariableName` sniff.
jrfnl Aug 26, 2016
a78dba2
Changelog for the 0.10.0 version
jrfnl Aug 19, 2016
9599c4f
Fix VIP restricted function error.
jrfnl Aug 26, 2016
25b07b3
Merge pull request #671 from WordPress-Coding-Standards/feature/impro…
westonruter Aug 27, 2016
e600779
Merge branch 'develop' into feature/fix-incorrect-restricted-function
westonruter Aug 27, 2016
f32da4a
Merge pull request #670 from WordPress-Coding-Standards/feature/fix-i…
westonruter Aug 27, 2016
1c9224e
Merge branch 'develop' into feature/changelog-0.10.0
westonruter Aug 27, 2016
2f0d88c
Bump 0.10.0 release date to 2016-08-29
westonruter Aug 27, 2016
4db525d
Merge pull request #664 from WordPress-Coding-Standards/feature/chang…
westonruter Aug 29, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion WordPress-Core/ruleset.xml
Original file line number Diff line number Diff line change
@@ -9,6 +9,9 @@
<severity>0</severity>
</rule>

<!-- https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#use-elseif-not-else-if -->
<rule ref="PSR2.ControlStructures.ElseIfDeclaration"/>

<!-- http://make.wordpress.org/core/handbook/coding-standards/php/#remove-trailing-spaces -->
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace"/>

@@ -38,7 +41,7 @@
<rule ref="Squiz.Strings.DoubleQuoteUsage.ContainsVar">
<severity>0</severity>
</rule>

<rule ref="Generic.PHP.LowerCaseKeyword"/>

<rule ref="Generic.Files.LineEndings">