Always consider casting sanitization #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two different sanitization checks in this sniff. Only one of them was considering that casting is a form of input sanitization. I’ve moved the casting check out of the conditional it was in, and now the `$is_casted` value is being checked for all sanitization checking paths. Includes unit tests. Fixes WordPress#179
westonruter
added a commit
that referenced
this pull request
Jan 2, 2015
Always consider casting sanitization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two different sanitization checks in the
VIP.ValidatedSanitizedInputsniff. Only one ofthem was considering that casting is a form of input sanitization. I’ve
moved the casting check out of the conditional it was in, and now the
$is_castedvalue is being checked for all sanitization checking paths.Includes unit tests.
Fixes #179