Fix T_ELSE immediately followed by T_COLON

[nyordanov]

Curently else: throws two errors:

1. Space after opening control structure is required (the Coding Standards handbook doesn't say anything on this)
2. No space before opening parenthesis is prohibited (this is just wrong - there is no paranthesis on this line)

This pull request prevents the sniffer from throwing these two errors.

---

If my interpretation of 1. is considered correct, I could add a fixable error for else :

[JDGrimes]

I prefer the space (else :). I think the motto of the standards is "when in doubt, space it out."

[nyordanov]

In this case shouldn't if ( true ): throw an error?

[JDGrimes]

Yes, in my opinion. I always use the space there as well.

[nyordanov]

OK, it can be changed easily, but let's hear from @westonruter first?

[westonruter]

There are 44 instances of else : in Core, and 13 instances of else:. In terms of raw numbers, it would seem else : wins, but since both exist in core then it's probably better to not mandate one or the other.

@nyordanov could you add a new property to the sniff which would control the behavior for whether a space is required or not?

[nyordanov]

I've added public $space_before_colon_required = true; in ac62ce6

When the property is set to false, it's required that there is no space before T_COLON. The default value requires that there is a space.

[GaryJones]

In this case shouldn't if ( true ): throw an error?

The last snippet in the https://make.wordpress.org/core/handbook/coding-standards/php/#brace-style section has this documented with a space. I'd be happy to see : treated like a { and require the addition of a space before it as part of the definitive standard - anything else would be inconsistent.

[nyordanov]

@GaryJones it does now, see the tests in 5afd52c

The default settings of the sniff require that there is T_WHITESPACE before T_COLON when the T_COLON is a scope_opener of a control structure.

[GaryJones]

@GaryJones it does now, see the tests in 5afd52c

👍 Good job :-)

[westonruter]

@nyordanov This is some quality code. 👍 One thing, however, is the naming of the space_before_colon_required property. Personally if I were to set this to false then I would expect it a space to be optional. But it seems actually that if you set it false than an error will be raised if there is a space. So perhaps this property should be changed from a simple boolean to a string:

'space_before_colon' => 'required' # default
'space_before_colon' => 'optional' # same as if suppressing NoSpaceBetweenStructureColon
'space_before_colon' => 'forbidden' # your preferred style

[JDGrimes]

Related #17.