Core: add sniffs to check class/constant modifier keyword order #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up on 2102 This adds two new sniffs to the Core ruleset to cover the keyword modifier order rules for class declarations and OO constant declarations. Refs: * https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#visibility-and-modifier-order * WordPress/wpcs-docs 108 * PHPCSStandards/PHPCSExtra 142 * PHPCSStandards/PHPCSExtra 143
dingo-d
approved these changes
Dec 7, 2022
GaryJones
deleted the
feature/core-add-sniffs-for-class-constant-modifier-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #2102
This adds two new sniffs to the Core ruleset to cover the keyword modifier order rules for class declarations and OO constant declarations.
Refs:
Universal.Classes.ModifierKeywordOrdersniff PHPCSStandards/PHPCSExtra#142Universal.Constants.ModifierKeywordOrdersniff PHPCSStandards/PHPCSExtra#143