PHP 8.1 compatibility: fix deprecation notice [1] #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.1 deprecates passing `null` to PHP native functions where the parameter(s) is not explicitly nullable. While in PHP 8.1 this is only a deprecation, it should, of course, still be fixed. This commit contains a fix for the one of the two issues in WordPressCS found related to this so far (based on the unit tests). Passing `null` to `trim()` is now deprecated, so more defensive coding or explicit type casting is needed. This comes into play for the `MinimumWPVersionTrait::get_wp_version_from_cli()` method where the `Helper::getCommandLineData()` method can return either string or `null`. Ref: https://phpcsutils.com/phpdoc/classes/PHPCSUtils-BackCompat-Helper.html#method_getCommandLineData
dingo-d
approved these changes
Apr 7, 2021
Closed
websupporter
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Apr 1, 2022
We introduced the WordPress Coding standards, which are currently not compatible with PHP 8.1. We need to wait for the next major version to be able to upgrade to PHP 8.1. Example: WordPress/WordPress-Coding-Standards#1984 [MAILPOET-4219]
samnajian
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Apr 1, 2022
We introduced the WordPress Coding standards, which are currently not compatible with PHP 8.1. We need to wait for the next major version to be able to upgrade to PHP 8.1. Example: WordPress/WordPress-Coding-Standards#1984 [MAILPOET-4219]
samnajian
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Apr 1, 2022
We introduced the WordPress Coding standards, which are currently not compatible with PHP 8.1. We need to wait for the next major version to be able to upgrade to PHP 8.1. Example: WordPress/WordPress-Coding-Standards#1984 [MAILPOET-4219]
samnajian
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Apr 1, 2022
We introduced the WordPress Coding standards, which are currently not compatible with PHP 8.1. We need to wait for the next major version to be able to upgrade to PHP 8.1. Example: WordPress/WordPress-Coding-Standards#1984 [MAILPOET-4219]
samnajian
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Apr 1, 2022
We introduced the WordPress Coding standards, which are currently not compatible with PHP 8.1. We need to wait for the next major version to be able to upgrade to PHP 8.1. Example: WordPress/WordPress-Coding-Standards#1984 [MAILPOET-4219]
samnajian
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Apr 1, 2022
We introduced the WordPress Coding standards, which are currently not compatible with PHP 8.1. We need to wait for the next major version to be able to upgrade to PHP 8.1. Example: WordPress/WordPress-Coding-Standards#1984 [MAILPOET-4219]
JanJakes
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Apr 4, 2022
We introduced the WordPress Coding standards, which are currently not compatible with PHP 8.1. We need to wait for the next major version to be able to upgrade to PHP 8.1. Example: WordPress/WordPress-Coding-Standards#1984 [MAILPOET-4219]
veljkho
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Apr 4, 2022
We introduced the WordPress Coding standards, which are currently not compatible with PHP 8.1. We need to wait for the next major version to be able to upgrade to PHP 8.1. Example: WordPress/WordPress-Coding-Standards#1984 [MAILPOET-4219]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 deprecates passing
nullto PHP native functions where the parameter(s) is not explicitly nullable.While in PHP 8.1 this is only a deprecation, it should, of course, still be fixed.
This commit contains a fix for the one of the two issues in WordPressCS found related to this so far (based on the unit tests).
Passing
nulltotrim()is now deprecated, so more defensive coding or explicit type casting is needed.This comes into play for the
MinimumWPVersionTrait::get_wp_version_from_cli()method where theHelper::getCommandLineData()method can return either string ornull.Ref: https://phpcsutils.com/phpdoc/classes/PHPCSUtils-BackCompat-Helper.html#method_getCommandLineData