Improve global function call detection #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oken_namespaced()` These should help make the checking of whether or not a function call is a global function, method call or a namespaced function call more consistent. These functions will be unit tested by the implementations in various other places and the fact that the existing unit tests still pass after that.
…s_token_namespaced()
… and Sniff::is_token_namespaced()
GaryJones
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sniff: add two new utility methodsis_class_object_call()andis_token_namespaced()These should help make the checking of whether or not a function call is a global function, method call or a namespaced function call more consistent.
This also implements allowing for the
namespacekeyword being used as an operator, though this may yield false negatives when the operator is used in a non-namespaced file, but I rate the chances of that happening as small.These functions will be unit tested by the implementations in various other places and the fact that the existing unit tests still pass after that.
Loosely related to #764
Implement the new methods
In:
Sniff::is_in_isset_or_empty()Sniff::is_validated()Sniff::is_use_of_global_constant()AbstractFunctionRestrictionsSniffWordPress.WP.GlobalVariablesOverrideWordPress.WP.DiscouragedConstants