Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative look behind to exclude object methods #1536

Closed
wants to merge 1 commit into from

Conversation

roborourke
Copy link

@roborourke roborourke commented Nov 14, 2018

This should prevent false negatives for object methods that match the name of any translation functions.

Related to #1535

@jrfnl
Copy link
Member

jrfnl commented Nov 14, 2018

@roborourke Thank you for your willingness to contribute,

However, the regexes you adjusted are for sprintf() placeholders, i.e. %2$s within strings, and would be broken by this "fix".
This is not the part of the code used to determine whether something is a function call or not. See #1267 for how it was actually fixed.

Closing as wrong solution for a problem which is already solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants