Composer: various tweaks #1488
Merged
Composer: various tweaks #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two additional scripts and adjusts the existing one. The additional scripts are just shortcuts to run `phpcs` and `phpcbf`. The more important change is how the scripts are run - using the `@php` prefix ensures that the scripts are run against the same PHP version as with which Composer is called, instead of against the system default PHP version. This is important if - as a WPCS dev - you change the PHP version for Composer to be able to test things against different PHP versions. Ref: composer/composer#7645
GaryJones
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two additional scripts and adjusts the existing one.
The additional scripts are just shortcuts to run
phpcsandphpcbf.The more important change is how the scripts are run - using the
@phpprefix ensures that the scripts are run against the same PHP version as with which Composer is called, instead of against the system default PHP version.This is important if - as a WPCS dev - you change the PHP version for Composer to be able to test things against different PHP versions.
Ref: composer/composer#7645