Core: New sniff to examine type casts #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sniff will check that PHP type casts are: - lowercase; - short form, i.e. (bool) not (boolean); - normalized, i.e. (float) not (real). The sniff also discourages the use of the `(unset)` and the `(binary)` casts, including the `b"$string"` binary cast, though it is susceptible to bug squizlabs/PHP_CodeSniffer 1574. The sniff has been added to the `WordPress-Core` ruleset. Once the minimum PHPCS version has gone up to PHPCS 3.3.0+, the lowercase check part of the sniff can be removed in favour of adding the `Generic.PHP.LowerCaseType` sniff to the ruleset instead. Fixes 1481
GaryJones
approved these changes
Sep 11, 2018
JDGrimes
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sniff will check that PHP type casts are:
The sniff also discourages the use of the
(unset)and the(binary)casts, including theb"$string"binary cast, though it is susceptible to bug squizlabs/PHP_CodeSniffer#1574.The sniff has been added to the
WordPress-Coreruleset.Once the minimum PHPCS version has gone up to PHPCS 3.3.0+, the lowercase check part of the sniff can be removed in favour of adding the
Generic.PHP.LowerCaseTypesniff to the ruleset instead.Fixes #1481