Sniff::is_in_isset_or_empty(): improve code-style independence #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes unit tests in the ValidatedSanitizedInput test case file.
jrfnl
force-pushed
the
feature/is_in_isset_or_empty-codestyle-independence
branch
from
9cdf7ad to
b4b50a6
Compare
GaryJones
reviewed
Aug 28, 2018
| @@ -1505,7 +1505,8 @@ protected function is_in_isset_or_empty( $stackPtr ) { | |||
| end( $nested_parenthesis ); | |||
| $open_parenthesis = key( $nested_parenthesis ); | |||
|
|
|||
| return \in_array( $this->tokens[ ( $open_parenthesis - 1 ) ]['code'], array( \T_ISSET, \T_EMPTY ), true ); | |||
There was a problem hiding this comment.
So when looking for code-style assumptions, a good starting point is $this->tokens[ $var +/- X ]?
There was a problem hiding this comment.
Yes and no. doing that calculation is very common and correct when it's to set the starting point for a findNext()/findPrevious() function call.
Code style assumptions are only problematic for best practice sniffs, not code style sniffs and to bypass those assumption you need to take every crappy way of writing PHP into account, so looking for checks using T_WHITESPACE is another typical search entry point. This should - for code style independence - be Tokens::$emptyTokens.
GaryJones
approved these changes
Aug 28, 2018
|
@WordPress-Coding-Standards/wpcs-admins Anything I can do to move this PR forward ? |
JDGrimes
approved these changes
Sep 7, 2018
JDGrimes
deleted the
feature/is_in_isset_or_empty-codestyle-independence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes unit tests in the ValidatedSanitizedInput test case file.
Relates to #763