EscapeOutput: fix various bugs #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PHPCS `findEndOfStatement()` method returns the end token òr the last non-whitespace token if the end token is a "bracket", like a closing parenthesis. In effect, this meant that the last token in a `trigger_error()` function call was never examined and that the sniff would underreport. Fixed now. Includes unit tests.
If `$end_of_statement` had not been determined, the sniff would report report on `OutputNotEscaped`, but not on `UnsafePrintingFunction`s. To report on `UnsafePrintingFunction`s, the code in the condition does not actually need the `$end_of_statement`, so this minor logic change allows for the sniff to report the correct error.
The sniff would up to now not handle short arrays correctly and would report on the open/close brackets, not on the content of the array. Includes unit tests.
GaryJones
approved these changes
Mar 31, 2018
JDGrimes
approved these changes
Mar 31, 2018
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this pull request
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EscapeOutput: report correctly on first param of
trigger_error()The PHPCS
findEndOfStatement()method returns the end token òr the last non-whitespace token if the end token is a "bracket", like a closing parenthesis.In effect, this meant that the last token in a
trigger_error()function call was never examined and that the sniff would underreport.Fixed now. Includes unit tests.
EscapeOutput: correctly report on unsafe printing functions
If
$end_of_statementhad not been determined, the sniff would report onOutputNotEscaped, not onUnsafePrintingFunctions.To report on
UnsafePrintingFunctions, the code in the condition does not actually need the$end_of_statement, so this minor logic change allows for the sniff to report the correct error.EscapeOutput: allow for short arrays
The sniff would up to now not handle short arrays correctly and would report on the open/close brackets, not on the content of the array.
Includes unit tests.
Related #764