Expected 0 spaces between "(" and comma; 1 found - false positive ?

[westonruter]

I'm receiving this error for a certain project and can't for the life of me figure out what is meant by it and/or how it applies to the indicated lines.

Not sure whether this is a false positive or whether I'm just being stupid ;-) On that note, there are a few other projects where I'm getting strange (unexplainable) sniff errors from, again possibly false positives. Should these be reported here ? I couldn't find anything about it in the contributing notes.

Below are the lines causing the errors (from the Mimetype Link Icons plugin and used in a function which returns the input used for wp_localize_script() ):

$strings = array(
    'hidethings'            => ( ( true === $this->settings['enable_hidden_class'] && ( is_array( $this->settings['hidden_classname'] ) && array() !== $this->settings['hidden_classname'] ) ) ? true : false ),
    'enable_async'          => ( ( true === $this->settings['enable_async'] && ( is_array( $this->active_mimetypes ) && array() !== $this->active_mimetypes ) ) ? true : false ),
    'enable_async_debug'    => ( ( true === $this->settings['enable_async_debug'] && ( is_array( $this->active_mimetypes ) && array() !== $this->active_mimetypes ) ) ? true : false ),
);

[westonruter]

It does seem to be a false positive (or negative)?

Here is the code in question which flags the error: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/blob/e16ca46b6df78dcf45cc2af588907d14fc57184a/Sniffs/Arrays/ArrayDeclarationSniff.php#L428-L434

[westonruter]

@shadyvb when you have a moment, can you debug this?

[shadyvb]

@westonruter I think it was a left-over from a previous ticket, with some faulty unit-test which was modified later. Undoing the fix of #59 did not break unit tests but it solves this ticket here.

[jrfnl]

@shadyvb @westonruter Thank you!