PrefixAllGlobals: make the prefix comparison more code style independent #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for prefixed functions, classes, hooks in camelCase and other naming conventions. Fixes 1239
Bug fix. Invalid prefixes which did not pass the second validation check would still be added to the `validated_prefixes` array and the sniff would still run, even though no valid prefixes were available.
JDGrimes
approved these changes
Jan 4, 2018
GaryJones
deleted the
feature/1239-prefix-all-globals-code-style-independence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for prefixed functions, classes, hooks in camelCase and other naming conventions.
Fixes #1239
While looking at the prefix check, I noticed a secondary bug which is fixed in a separate commit:
Invalid prefixes which did not pass the second validation check would still be added to the
validated_prefixesarray and the sniff would still run, even though no valid prefixes were available.