XSS.EscapeOutput sniff: Fix issue #933 - namespace separators. #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simple change means that namespace separators will be be ignored completely by the check for output escaping which fixes the immediate issue. For a more thorough fix, the logic of the function would need to be refactored to take namespaced functions into account as well, but that's for another day.
GaryJones
approved these changes
Aug 8, 2017
|
Works perfectly for my case :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple change means that namespace separators will be be ignored completely by the check for output escaping which fixes the immediate issue.
For a more thorough fix, the logic of the function would need to be refactored to take namespaced functions into account as well, but that's for another day.
Fixes #933