Update README.md to include Atom setup tips #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give readers a heads up that the tab width needs to be explicitly changed in the package settings and that certain config options may present problems.
jrfnl
reviewed
Aug 4, 2017
README.md
Outdated
| @@ -213,11 +213,14 @@ sublime-phpcs is insanely powerful, but if you'd prefer automatic linting, [Subl | |||
| - Install [linter-phpcs](https://atom.io/packages/linter-phpcs) via Atom's package manager. | |||
| - Run `which phpcs` to get your `phpcs` executable path. | |||
| - Enter your `phpcs` executable path and one of the coding standards specified above (e.g. `WordPress`, `WordPress-VIP`, etc.). | |||
| - Change the Tab Width setting to `4`. | |||
There was a problem hiding this comment.
Do Atom users know where to find that setting ? Or should the instruction on where to change this be made more specific ?
There was a problem hiding this comment.
Agreed, see 1a18cfd
Frankly the instructions as they were weren't completely clear, hopefully this helps :)
GaryJones
approved these changes
Aug 4, 2017
jrfnl
approved these changes
Aug 4, 2017
|
Thanks @jaredatch! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give readers a heads up that the tab width needs to be explicitly changed in the package settings and that certain config options may present problems.
Fixes #1082