PHPCS 3.x compat: Implement recognition of the --ignore-annotations setting
#1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryJones
approved these changes
Jul 25, 2017
JDGrimes
reviewed
Jul 25, 2017
WordPress/PHPCSHelper.php
Outdated
| * @return bool True if annotations should be ignored, false otherwise. | ||
| */ | ||
| public static function ignore_annotations( File $phpcsFile = null ) { | ||
| // @TODO THIS NEEDS SOME CAREFUL & THOROUGH TESTING! |
There was a problem hiding this comment.
I'm assuming that this comment is intended to be left in the code for now?
There was a problem hiding this comment.
Oh darn! No, that comment should be removed. Was a WIP comment to myself & I have tested it since and confirmed it works as expected.
There was a problem hiding this comment.
@JDGrimes I've removed the comment now.
… setting See issue 862
jrfnl
force-pushed
the
WPCS-0.13.0/feature/phpcs-3.x-support-ignore-annotations
branch
from
49b7f3e to
6dc72a5
Compare
JDGrimes
deleted the
WPCS-0.13.0/feature/phpcs-3.x-support-ignore-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the PHPCS 3.x compatibility PR series.
PHPCS 3.x introduces a
--ignore-annotationscommand line option to ignore any and all inline file ignore / line ignore / coding standard setting changes etc.This PR ensures that the WPCS specific whitelist comments will also be ignored if the
--ignore-annotationscommand line option is passed.Fixes #862