Flag any non-validated/sanitized super global input vars #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #72 Switch list of sanitizing/autoescaping function to a static var to be used by other classes
ghost
assigned 
| return; | ||
| } | ||
|
|
||
| if (in_array($functionName, $this->sanitizingFunctions) === false) { | ||
| if (in_array($functionName, self::$sanitizingFunctions) === false) { |
There was a problem hiding this comment.
@shadyvb just curious: why the switch from instance to static?
There was a problem hiding this comment.
So i can use the list of functions in other classes, https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/101/files#diff-6693bc98032bf5043abf5d11967faf4aR104
There was a problem hiding this comment.
Instead of replicating the exact same list again.
| empty( $_REQUEST['foo'] ) | ||
| || | ||
| empty( $_POST['foo'] ) | ||
| ); |
There was a problem hiding this comment.
@shadyvb I added this use of empty() which should be fine just like isset() but it is not.
There was a problem hiding this comment.
My bad, fix is on the way!
|
@shadyvb could you please merge |
…ress-Coding-Standards into issue/72 Conflicts: Sniffs/XSS/EscapeOutputSniff.php
westonruter
added a commit
that referenced
this pull request
Oct 23, 2013
Flag any non-validated/sanitized super global input vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72