Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag use of extract() #90

Closed
1 task done
westonruter opened this issue Oct 11, 2013 · 0 comments · Fixed by #106
Closed
1 task done

Flag use of extract() #90

westonruter opened this issue Oct 11, 2013 · 0 comments · Fixed by #106
Assignees
@westonruter
Milestone
WordPress VIP Rules

Comments

@westonruter
Copy link
Member

  • Flag any instance of the function extract()

Using extract() #

extract() should never be used because it is too opaque and difficult to understand how it will behave under a variety of inputs. It makes it too easy to introduce new variables into a function’s scope without knowing about it, potentially causing unintended and difficult to debug conflicts.
shadyvb added a commit that referenced this issue Oct 23, 2013
@shadyvb
Flag use of extract() #90
d83cfd5
@ghost ghost assigned westonruter Oct 23, 2013
@shadyvb shadyvb mentioned this issue Oct 23, 2013
Merged
jrfnl added a commit that referenced this issue Jul 15, 2016
@jrfnl
Separate out the sniffing for extract().
6028359 
Currently only VIP checked for the usage of `extract()`, even though it is an explicit rule for core.

Ref: https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#dont-extract

Solved #90 for real ;-)
@jrfnl jrfnl mentioned this issue Jul 15, 2016
Merged
grappler referenced this issue in WPTT/WPThemeReview Sep 25, 2016
@jrfnl @grappler
Separate out the sniffing for extract().
c6a5a8e 
Currently only VIP checked for the usage of `extract()`, even though it is an explicit rule for core.

Ref: https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#dont-extract

Solved #90 for real ;-)
JDGrimes pushed a commit that referenced this issue Oct 8, 2016
@jrfnl @JDGrimes
Separate out the sniffing for extract().
6d4a693 
Currently only VIP checked for the usage of `extract()`, even though it is an explicit rule for core.

Ref: https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#dont-extract

Solved #90 for real ;-)
grappler pushed a commit to grappler/WordPress-Coding-Standards that referenced this issue Dec 17, 2016
@jrfnl
Merge pull request WordPress#90 from WPTRT/feature/issue-3-4-mixed-li…
0b822a2 
…ne-endings

Mark mixed line endings as error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonruter westonruter

Labels
None yet
Projects
None yet
Milestone
WordPress VIP Rules
Development

Successfully merging a pull request may close this issue.

Function restrictions sniff WordPress/WordPress-Coding-Standards
1 participant
@westonruter