Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0? #519

Closed
JDGrimes opened this issue Feb 1, 2016 · 6 comments
Closed

1.0.0? #519

JDGrimes opened this issue Feb 1, 2016 · 6 comments

Comments

@JDGrimes
Copy link
Contributor

JDGrimes commented Feb 1, 2016

Since I just released 0.9.0, I guess it is a good time to decide whether the next version should be 1.0.0 or 0.10.0. It really doesn't matter to me. Any thoughts?

@westonruter
Copy link
Member

I guess the question is whether or not we consider the project to ever come to a point where it would not be backwards-compatible. If so, then a major version break would make sense. If we feel that in its current state the project is stable and a foundation to build upon, declaring a 1.0.0 would communicate that we feel it is a mature project. But then I should think that we never arrive at a 2.0.0, but just keep bumping the minor version each month, so in a couple years we could have 1.24.0

@JDGrimes
Copy link
Contributor Author

JDGrimes commented Feb 1, 2016

There will definitely be times where we have to break back compat, just because PHPCS itself will. When PHPCS 3.0 is released, for example, we'll need to release a new version of WPCS that will not be compatible with PHPCS 2.0.

Other than that, we probably will have little need to ever break back-compat.

So maybe we wait until PHPCS 3.0 comes out and then decide if we want to release a 1.0 then? Or we could release a 1.0 now and release a 2.0 then, if we think that WPCS is mature.

@JDGrimes
Copy link
Contributor Author

JDGrimes commented Feb 1, 2016

There are two different things to consider in terms of compatibility here: the code itself (for people that are creating custom child sniffs) and the configuration. PHPCS 3.0 will break code back-compat, but not necessary configuration.

@GaryJones
Copy link
Member

I'd vote for 0.10.0.

  1. Once you move to 1.0.0, you can't go back.
  2. There are big areas of WP PHP Inline Documentation standards that we don't cover (or claim to cover), so a 1.0 would seem presumptuous in that regard.
  3. Until the big holes in the WP standards have been unambiguously filled, I wouldn't want folks to think that we're the canonical authority on all aspects of how all WP code should be written, just because we're 1.0.

@westonruter
Copy link
Member

I'd vote for 0.10.0.

👍 Great arguments.

@JDGrimes
Copy link
Contributor Author

JDGrimes commented Feb 2, 2016

👍 0.10.0 it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants