Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semver / version 1.0.0 #1247

Closed
jrfnl opened this issue Dec 1, 2017 · 4 comments
Closed

Semver / version 1.0.0 #1247

jrfnl opened this issue Dec 1, 2017 · 4 comments

Comments

@jrfnl
Copy link
Member

jrfnl commented Dec 1, 2017

Previously discussed in #287 and #519 and touched upon in #718 and #1157.

As the big CS patch has gone into WP Core now and I'm proposing breaking changes for version 0.15.0 in #1157, I think it's time to revisit the Semver discussion.

Version 0.13.0 also contained breaking changes up to a point: for any standard which based itself on WPCS.
Now 0.15.0 will contain breaking changes - but with proposal 2 will stabilize the location of a number of sniffs to more logical places in the hierarchy.
Version 0.17.0 or 0.18.0 - depending on how we go - will again contain breaking changes as we'll be dropping PHPCS 2.x support and removing previously deprecated sniffs as well as removing sniffs where we can defer to upstream sniffs once the minimum PHPCS requirement has gone up to PHPCS 3.x as per #1048.

Keeping all that in mind, I think it's time.

Using Semver will allow us to better communicate what people can expect from a release, making it less painful to upgrade.

So, if people agree, this would mean that 0.15.0 would become the 1.0.0 release. If we call it 1.0.0 which would clearly signal a breaking change, it would also not necessarily just and only need to contain the breaking changes. We could then allow other finished PRs to also enter into the release.

And, unless there are breaking changes before that time, the "drop PHPCS 2.x support" release would become version 2.0.0.

Opinions ?

/cc @WordPress-Coding-Standards/wpcs-admins

Refs:

@JDGrimes
Copy link
Contributor

JDGrimes commented Dec 1, 2017

I would probably opt to wait and make the "drop PHPCS 2.x support" release 1.0.0, but I can't really think of a good reason to do that, other than that it just wouldn't feel like time for 2.0.0 yet. So I guess if there are no objections, we may as well go ahead and make this release 1.0.0.

@GaryJones
Copy link
Member

It's a good a time as any.

@ntwb
Copy link
Member

ntwb commented Dec 2, 2017

Go for it 🎉

@jrfnl
Copy link
Member Author

jrfnl commented Dec 14, 2017

As there is clearly consensus, I've renamed the 0.15.0 milestone to 1.0.0 and added some more milestones for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants