Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP: Add whitelisting comment for tax_query #479

Closed
westonruter opened this issue Oct 26, 2015 · 0 comments
Closed

VIP: Add whitelisting comment for tax_query #479

westonruter opened this issue Oct 26, 2015 · 0 comments

Comments

@westonruter
Copy link
Member

Sometimes tax_query is just required. The WordPress-VIP standard will raise an warning for this, and there is no whitelisting comment to suppress the warning, meaning that something like this is required:

// @codingStandardsIgnoreStart
$args['tax_query'] = $tax_query;
// @codingStandardsIgnoreEnd

This isn't ideal, and it would be better to have:

$args['tax_query'] = $tax_query; // WPCS: tax_query ok

With this change, the Wiki would need to be updated: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Whitelisting-code-which-flags-errors

wesm87 added a commit to wesm87/WordPress-Coding-Standards that referenced this issue Feb 5, 2016

Verified

This commit was signed with the committer’s verified signature.
Exirel Florian Strzelecki
JDGrimes pushed a commit that referenced this issue Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants