Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add identifier to all errors and warnings in custom sniffs #386

Closed
GaryJones opened this issue May 14, 2015 · 3 comments
Closed

Add identifier to all errors and warnings in custom sniffs #386

GaryJones opened this issue May 14, 2015 · 3 comments
Labels
Type: Enhancement
Milestone
0.8.0

Comments

@GaryJones
Copy link
Member

Including a unique identifier in all errors and warnings in our custom sniffs allows developers to target them to exclude them from reports without disabling the whole sniff.
@JDGrimes
Copy link
Contributor

Previously: #297

So most of the errors/warnings should have an identifier.

@JDGrimes
Copy link
Contributor

Note that this will be required in PHPCS 3.0 (see squizlabs/PHP_CodeSniffer@c587b27#diff-34ae68f4adad56c25c5bc05dcb64794eR33).

@JDGrimes
Copy link
Contributor

JDGrimes commented Jun 1, 2015

One sniff that doesn't have a uid for each error is VIP.DirectDatabaseQuery.

JDGrimes added a commit that referenced this issue Jun 5, 2015
@JDGrimes
Specify an error code for each error
b2671b1 
See #386
@JDGrimes JDGrimes added this to the 0.8.0 milestone Aug 30, 2015
@JDGrimes JDGrimes self-assigned this Aug 30, 2015
JDGrimes added a commit that referenced this issue Sep 18, 2015
@JDGrimes
Add error codes to all messages
60de5bd 
Fixes #386
@JDGrimes JDGrimes mentioned this issue Sep 18, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@GaryJones @JDGrimes