-
-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array declaration sniff should account for places where WP expects mixed key/no-key arrays #146
Comments
It seems we should eliminate this warning from the sniff. There is actually no reference to a forbidden mixing of explicit keys and implied numerical keys in the WordPress Coding Standards: http://make.wordpress.org/core/handbook/coding-standards/php/ |
@westonruter Just commented that problematic warning in #204 |
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Apr 22, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Apr 22, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Apr 26, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
May 15, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Jun 17, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Jun 17, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Jun 25, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Jul 22, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Aug 7, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Aug 10, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
jrfnl
added a commit
to jrfnl/WordPress-Coding-Standards
that referenced
this issue
Aug 12, 2022
Using the `dealerdirect/phpcodesniffer-composer-installer` Composer plugin is recommended to register external PHPCS standards with PHPCS. As of Composer 2.2.0, Composer plugins need to be explicitly allowed to run. This commit: * Adds the necessary configuration for that to the `composer.json` for this project. * Adds the CLI command to set those permissions to the installation instructions for consumer projects. Includes updating the URL references to the plugin to point to the new home of the plugin. (see [upstream issue WordPress#146](PHPCSStandards/composer-installer#146)) Refs: * https://blog.packagist.com/composer-2-2/#more-secure-plugin-execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The array syntax sniff will report when an array has some values assigned specific keys and others not.
This causes a problem where WordPress requires mixed arrays, as in the
'meta_query'
argument forWP_Query
:The sniff should probably ignore any key if its text is
'related'
.The text was updated successfully, but these errors were encountered: