Consistent class exists check for extended classes.

Ensure that any sniff with a dependency on an external sniff has a consistent `class_exists()` check and throws an appropriate error message.
WordPress · Jul 29, 2016 · de73645 · de73645
1 parent 9d0d32d
commit de73645
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 2 deletions.
diff --git a/WordPress/Sniffs/Arrays/ArrayDeclarationSniff.php b/WordPress/Sniffs/Arrays/ArrayDeclarationSniff.php
@@ -9,6 +9,10 @@
  * @author   Marc McIntyre <[email protected]>
  */
 
+if ( ! class_exists( 'Squiz_Sniffs_Arrays_ArrayDeclarationSniff', true ) ) {
+	throw new PHP_CodeSniffer_Exception( 'Class Squiz_Sniffs_Arrays_ArrayDeclarationSniff not found' );
+}
+
 /**
  * Enforces WordPress array format.
  *

diff --git a/WordPress/Sniffs/NamingConventions/ValidFunctionNameSniff.php b/WordPress/Sniffs/NamingConventions/ValidFunctionNameSniff.php
@@ -7,6 +7,10 @@
  * @author   John Godley <[email protected]>
  */
 
+if ( ! class_exists( 'PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff', true ) ) {
+	throw new PHP_CodeSniffer_Exception( 'Class PEAR_Sniffs_NamingConventions_ValidFunctionNameSniff not found' );
+}
+
 /**
  * Enforces WordPress function name and method name format, based upon Squiz code.
  *

diff --git a/WordPress/Sniffs/NamingConventions/ValidVariableNameSniff.php b/WordPress/Sniffs/NamingConventions/ValidVariableNameSniff.php
@@ -15,7 +15,7 @@
  * @link      http://pear.php.net/package/PHP_CodeSniffer
  */
 
-if ( class_exists( 'PHP_CodeSniffer_Standards_AbstractVariableSniff', true ) === false ) {
+if ( ! class_exists( 'PHP_CodeSniffer_Standards_AbstractVariableSniff', true ) ) {
 	throw new PHP_CodeSniffer_Exception( 'Class PHP_CodeSniffer_Standards_AbstractVariableSniff not found' );
 }
 

diff --git a/WordPress/Sniffs/PHP/DiscouragedFunctionsSniff.php b/WordPress/Sniffs/PHP/DiscouragedFunctionsSniff.php
@@ -7,7 +7,7 @@
  * @author   John Godley <[email protected]>
  */
 
-if ( false === class_exists( 'Generic_Sniffs_PHP_ForbiddenFunctionsSniff', true ) ) {
+if ( ! class_exists( 'Generic_Sniffs_PHP_ForbiddenFunctionsSniff', true ) ) {
 	throw new PHP_CodeSniffer_Exception( 'Class Generic_Sniffs_PHP_ForbiddenFunctionsSniff not found' );
 }
 

diff --git a/WordPress/Sniffs/VIP/FileSystemWritesDisallowSniff.php b/WordPress/Sniffs/VIP/FileSystemWritesDisallowSniff.php
@@ -7,6 +7,10 @@
  * @link     https://make.wordpress.org/core/handbook/best-practices/coding-standards/
  */
 
+if ( ! class_exists( 'Generic_Sniffs_PHP_ForbiddenFunctionsSniff', true ) ) {
+	throw new PHP_CodeSniffer_Exception( 'Class Generic_Sniffs_PHP_ForbiddenFunctionsSniff not found' );
+}
+
 /**
  * Disallow Filesystem writes.
  *

diff --git a/WordPress/Sniffs/VIP/SessionFunctionsUsageSniff.php b/WordPress/Sniffs/VIP/SessionFunctionsUsageSniff.php
@@ -7,6 +7,10 @@
  * @link     https://make.wordpress.org/core/handbook/best-practices/coding-standards/
  */
 
+if ( ! class_exists( 'Generic_Sniffs_PHP_ForbiddenFunctionsSniff', true ) ) {
+	throw new PHP_CodeSniffer_Exception( 'Class Generic_Sniffs_PHP_ForbiddenFunctionsSniff not found' );
+}
+
 /**
  * WordPress_Sniffs_VIP_SessionFunctionsUsageSniff.
  *

diff --git a/WordPress/Sniffs/VIP/SessionVariableUsageSniff.php b/WordPress/Sniffs/VIP/SessionVariableUsageSniff.php
@@ -7,6 +7,10 @@
  * @link     https://make.wordpress.org/core/handbook/best-practices/coding-standards/
  */
 
+if ( ! class_exists( 'Generic_Sniffs_PHP_ForbiddenFunctionsSniff', true ) ) {
+	throw new PHP_CodeSniffer_Exception( 'Class Generic_Sniffs_PHP_ForbiddenFunctionsSniff not found' );
+}
+
 /**
  * WordPress_Sniffs_VIP_SessionVariableUsageSniff
  *

diff --git a/WordPress/Sniffs/VIP/TimezoneChangeSniff.php b/WordPress/Sniffs/VIP/TimezoneChangeSniff.php
@@ -7,6 +7,10 @@
  * @link     https://make.wordpress.org/core/handbook/best-practices/coding-standards/
  */
 
+if ( ! class_exists( 'Generic_Sniffs_PHP_ForbiddenFunctionsSniff', true ) ) {
+	throw new PHP_CodeSniffer_Exception( 'Class Generic_Sniffs_PHP_ForbiddenFunctionsSniff not found' );
+}
+
 /**
  * WordPress_Sniffs_VIP_TimezoneChangeSniff.
  *