deprecated the Admin Bar Removal Sniff

WordPress-VIP/ruleset.xml

@@ -131,6 +131,11 @@
 	#############################################################################
 	-->
 
+	<!-- Prevent deprecation notice when the sniff is not explicitely included. -->
+	<rule ref="WordPress.VIP.AdminBarRemovalSniff.DeprecatedSniff">
+		<severity>0</severity>
+	</rule>
+
 	<!-- Prevent deprecation notice when the sniff is not explicitely included. -->
 	<rule ref="WordPress.VIP.DirectDatabaseQuery.DeprecatedSniff">
 		<severity>0</severity>

WordPress/Sniffs/VIP/AdminBarRemovalSniff.php

@@ -24,9 +24,32 @@
  *                 - Added the $remove_only property.
  *                 - Now also sniffs for manipulation of the admin bar visibility through CSS.
  * @since   0.13.0 Class name changed: this class is now namespaced.
+ *
+ * @deprecated 1.0.0  This sniff has been deprecated.
+ *                    This file remains for now to prevent BC breaks.
  */
 class AdminBarRemovalSniff extends AbstractFunctionParameterSniff {
 
+	/**
+	 * If true, an error will be thrown; otherwise a warning.
+	 *
+	 * @var bool
+	 */
+	public $error = true;
+
+	/**
+	 * Keep track of whether the warnings have been thrown to prevent
+	 * the messages being thrown for every token triggering the sniff.
+	 *
+	 * @since 1.0.0
+	 *
+	 * @var array
+	 */
+	private $thrown = array(
+		'DeprecatedSniff'                 => false,
+		'FoundPropertyForDeprecatedSniff' => false,
+	);
+
 	/**
 	 * A list of tokenizers this sniff supports.
 	 *
@@ -171,11 +194,29 @@ public function register() {
 	 *
 	 * @param int $stackPtr The position of the current token in the stack.
 	 *
+	 * @deprecated 1.0.0 Adjusted to allow for throwing the deprecation notices.
+	 * 
 	 * @return int|void Integer stack pointer to skip forward or void to continue
 	 *                  normal file processing.
 	 */
 	public function process_token( $stackPtr ) {
 
+		if ( false === $this->thrown['DeprecatedSniff'] ) {
+			$this->thrown['DeprecatedSniff'] = $this->phpcsFile->addWarning(
+				'The "WordPress.VIP.AdminBarRemovalSniff" sniff has been deprecated. Please update your custom ruleset.',
+				0,
+				'DeprecatedSniff'
+			);
+		}
+
+		if ( false === $this->thrown['FoundPropertyForDeprecatedSniff'] ) {
+			$this->thrown['FoundPropertyForDeprecatedSniff'] = $this->phpcsFile->addWarning(
+				'The "WordPress.VIP.AdminBarRemovalSniff" sniff has been deprecated. Please update your custom ruleset.',
+				0,
+				'FoundPropertyForDeprecatedSniff'
+			);
+		}
+
 		$file_name      = $this->phpcsFile->getFileName();
 		$file_extension = substr( strrchr( $file_name, '.' ), 1 );
 

WordPress/Tests/VIP/AdminBarRemovalUnitTest.php

@@ -85,10 +85,27 @@ public function getErrorList( $testFile = '' ) {
 	/**
 	 * Returns the lines where warnings should occur.
 	 *
+	 * @param string $testFile The name of the file being tested.
 	 * @return array <int line number> => <int number of warnings>
 	 */
-	public function getWarningList() {
-		return array();
+	public function getWarningList( $testFile = '' ) {
+		switch ( $testFile ) {
+			case 'AdminBarRemovalUnitTest.css':
+				return array(
+					1  => 2,
+				);
+
+			case 'AdminBarRemovalUnitTest.css':
+				return array(
+					1   => 1,
+				);
+
+			default:
+				return array();
+		}
+		return array(
+			1 => 2
+		);
 	}
 
 }