This should fix 5.2 failing

WordPress · Jul 21, 2016 · 5d5ec8f · 5d5ec8f
1 parent 1229cfc
commit 5d5ec8f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/WordPress/Sniffs/PHP/DisallowAlternativePHPTagsSniff.php b/WordPress/Sniffs/PHP/DisallowAlternativePHPTagsSniff.php
@@ -115,11 +115,9 @@ public function process( PHP_CodeSniffer_File $phpcsFile, $stackPtr ) {
 
 			return;
 		}
-if ( PHP_VERSION_ID < 50300 ) {
-var_dump( $openTag );
-}
-		// Account for incorrect script open tags.
-		if ( T_INLINE_HTML === $openTag['code'] && 1 === preg_match( '`(<script (?:[^>]+)?language=[\'"]?php[\'"]?(?:[^>]+)?>)`i', $content, $match ) ) {
+
+		// Account for incorrect script open tags. The "(?:<s)?" in the regex is to work-around a bug in PHP 5.2.
+		if ( T_INLINE_HTML === $openTag['code'] && 1 === preg_match( '`((?:<s)?cript (?:[^>]+)?language=[\'"]?php[\'"]?(?:[^>]+)?>)`i', $content, $match ) ) {
 			$error   = 'Script style opening tag used; expected "<?php" but found "%s"';
 			$snippet = $this->get_snippet( $content, $match[1] );
 			$data    = array( $match[1] . $snippet );

diff --git a/WordPress/Tests/PHP/DisallowAlternativePHPTagsUnitTest.php b/WordPress/Tests/PHP/DisallowAlternativePHPTagsUnitTest.php
@@ -37,6 +37,15 @@ protected function setUp() {
 		}
 	}
 
+	/**
+	 * Skip this test on HHVM.
+	 *
+	 * @return bool Whether to skip this test.
+	 */
+	protected function shouldSkipTest() {
+		return defined( 'HHVM_VERSION' );
+	}
+
 	/**
 	 * Returns the lines where errors should occur.
 	 *