Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the text copy to 'register for event' #1448

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Change the text copy to 'register for event' #1448

merged 2 commits into from
Mar 30, 2023

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Mar 30, 2023

See #1003 (comment).

This PR

  • Replace text copy as requested
  • Add built CSS files path to .gitignore

Screenshot

image

@renintw renintw mentioned this pull request Mar 30, 2023
Closed
@renintw renintw requested a review from adamwoodnz March 30, 2023 00:59
@renintw renintw self-assigned this Mar 30, 2023
adamwoodnz
adamwoodnz approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

It will be interesting to see what happens when the sync is run, in theory those files are still in SVN control so once built they'll be committed as usual 🤞

@renintw renintw merged commit bcde399 into trunk Mar 30, 2023
@renintw renintw deleted the enhance/change-the-text-Register-for-event branch March 30, 2023 01:34
@renintw
Copy link
Contributor Author

renintw commented Mar 30, 2023

Things work as expected 🤞 🎉

Screen Shot 2023-03-30 at 9 39 21 AM

Screen Shot 2023-03-30 at 9 40 47 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwoodnz adamwoodnz adamwoodnz approved these changes

Assignees

@renintw renintw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renintw @adamwoodnz